search

renepickhardt / generalized-language-modeling-toolkit

Generalized Language Modeling toolkit
http://glm.rene-pickhardt.de
52 stars 17 forks source link

Mixup of boolean values absolute, continuation #85

Closed lschmelzeisen closed 9 years ago

lschmelzeisen commented 9 years ago

Currently in the code there is a complette mixup of booleans meaning absolute and continuation.

We have Pattern#isAbsolute() which returns true for absolute and false for continuation. We have Chunker#contination, Status#counted(boolean) which handles it reverse.

There are many more cases of this.

Those need to be refactored to a consistent way.

I suggest to use true for absolute and false for continuation everywhere.