Adding more features (in particular latency / bee line distance / IP distance)

renepickhardt / pickhardtpayments

python package to showcase, test and build your own version of Pickhardt Payments

Apache License 2.0

42 stars 14 forks source link

Adding more features (in particular latency / bee line distance / IP distance) #3

Open renepickhardt opened 2 years ago

renepickhardt commented 2 years ago

Right now the UncertaintyChannel is the place where we mainly provide two features for our cost function. It is pretty obvious that some feature representing physical distance / latency of channels should be included (though mathematically it does not really make sense to play with min cost flows). One option / roadmap:

integrate the property bee_line_distance to the Channel class
integrate the property latency to the OracleLightningNetwork class
derive a feature from the bee_line_distance in the UncertaintayChannel class

The downside with this Roadmap is that it does not properly generalize. It may be preferable to support an arbitrary amount or list of features.

RohitRathore1 commented 2 years ago

Where can I find the mentioned class in our codebase?

renepickhardt commented 2 years ago

Where can I find the mentioned class in our codebase?

The files in the package are literally named the same way the classes are named. All three files are located at: https://github.com/renepickhardt/pickhardtpayments/tree/main/pickhardtpayments

RohitRathore1 commented 2 years ago

Where can I find the mentioned class in our codebase?

The files in the package are literally named the same way the classes are named. All three files are located at: https://github.com/renepickhardt/pickhardtpayments/tree/main/pickhardtpayments

Aaah, sorry.

renepickhardt commented 2 years ago

Note that @TheBlueMatt hinted on Twitter that one could easily spin up VMs around the world and ping nodes to get an estimate of latency information / distance and @prusnak noted on twitter that one could use this openly licensed data base.