search

renero / 9floor

9th Floor Sailboats Factory
0 stars 0 forks source link

Issues in computeRawMoneyFlow function #29

Open javigd17 opened 9 years ago

javigd17 commented 9 years ago

@renero

Should not we use rawMoneyFlow.sliding(2) rather than closingValues.sliding(2)?

rawMoneyFlow variable is unused, so I guess it is a bug. isn't it?

renero commented 9 years ago

Again, not sure. I guess I'm using the closing values to decide what's the sign and build two separate vectors. Let me check again this morning.

javigd17 commented 9 years ago

Hold on

First, rawMoneyFlow is used in the last line, so forget my first comment but for deciding the sign:

shouldn't we use typical instead closingValues? I guess is what they use in chartSchool

http://stockcharts.com/school/doku.php?id=chart_school:technical_indicators:money_flow_index_mfi