Update project.py

[517qf]

Please check my ideas very carefully (I haven't tested it):

• Originally I just wanted a minor adjustment from {12,18} to {12,14}
• in the description of the method you write at beginning but the regex matches everywhere (I think). I'm not sure if the ^ also refers to the alternative?
• you want to match either twelve or fourteen, not thirteen
• I started with {14}, then {12} because if I started with {12} this would also match 14digit ids (and cut two digits at the end).
• your digits only consist of numbers so you can remove the . ?

I thought such a pull request might save you some work compared two yet another issue. dismiss it without comment if it saves you time.

[renerocksai]

• Why would you adjust to {12,14} in the first place???
• This would introduce rigidity where flexibility is better
• In other words: You're trying to fix something that does not need fixing
• This is not the only place where note IDs are matched -> inconsistency
• the description is misleading. it rather means return the first note id you encounter in the text. it is meant to find the next note id in text, even if the text starts with [[, for instance
• I don't want to match either 12 or 14 digits (the description is out of date, from sublime_zk, but the code is pretty clear about what it does)
• At the beginning: re.match would be a better fit for that purpose.
• The dot cannot be removed

There is some thinking behind this note ID regexp: Some people create notes (e.g. from highlighted sections in PDF files) in bulk via script. They obviously create more than 1 note per second. The dot, in this case, can be used to:

a) indicate that this is an autogenerated note, like 20180513021937.1 b) function as a millisecond separator

The length 18, thus, is perfect for creating notes with millisecond precision.

Creating a pull request is a great idea, as it indeed saves me time.

But here I have the very strong opinion that this part of the code does not need fixing, and it's better to keep the flexibility.

[517qf]

thanks for your detailed reply. This was very instructive for me. If you feel that I spam the issue list (in addition with far fetched stuff) let me know.

[renerocksai]

I am not going to censor you (yet 😄 ). You are entitled to your opinions, wishes, recommendations, suggestions, ...