search

renesas-rcar / arm-trusted-firmware

arm-trusted-firmware
Other
25 stars 39 forks source link

tools: Make invocation of host compiler correct #13

Open atomass opened 5 years ago

atomass commented 5 years ago

HOSTCC should be used in any of the tools inside the tools/ directory instead of CC. That way it is possible to override both values from the command line when building the Trusted Firmware and the tools at the same time. Also, use HOSTCCFLAGS instead of CFLAGS.

Also, instead of printing the strings CC and LD in the console during the compilation of the tools, HOSTCC and HOSTLD have to be used for clarity. This is how it is done in other projects like U-Boot or Linux.

Change-Id: Icd6f74c31eb74cdd1c353583399ab19e173e293e Signed-off-by: Antonio Nino Diaz antonio.ninodiaz@arm.com

Signed-off-by: Andrea Tomassetti andrea.tomassetti@silicon-gears.com

AlexeiFedorov commented 5 years ago

This patch should be submitted to https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a

Have you also seen: https://github.com/ARM-software/tf-issues/issues/656 ?

AlexeiFedorov commented 5 years ago

This patch should be submitted to https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a

Have you also seen: https://github.com/ARM-software/tf-issues/issues/656 ?

Alexei

From: Andrea Tomassetti notifications@github.com Sent: 11 June 2019 08:19 To: renesas-rcar/arm-trusted-firmware Cc: Subscribed Subject: [renesas-rcar/arm-trusted-firmware] tools: Make invocation of host compiler correct (#13)

HOSTCC should be used in any of the tools inside the tools/ directory instead of CC. That way it is possible to override both values from the command line when building the Trusted Firmware and the tools at the same time. Also, use HOSTCCFLAGS instead of CFLAGS.

Also, instead of printing the strings CC and LD in the console during the compilation of the tools, HOSTCC and HOSTLD have to be used for clarity. This is how it is done in other projects like U-Boot or Linux.

Change-Id: Icd6f74c31eb74cdd1c353583399ab19e173e293e Signed-off-by: Antonio Nino Diaz antonio.ninodiaz@arm.commailto:antonio.ninodiaz@arm.com

Signed-off-by: Andrea Tomassetti andrea.tomassetti@silicon-gears.commailto:andrea.tomassetti@silicon-gears.com

You can view, comment on, or merge this pull request online at:

https://github.com/renesas-rcar/arm-trusted-firmware/pull/13

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/renesas-rcar/arm-trusted-firmware/pull/13?email_source=notifications&email_token=ACTXTH2ERKK73CZ3ATBYKSTPZ5GX5A5CNFSM4HW3ICV2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYXNONQ, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACTXTH5OIKIBG5BS2CNBHXLPZ5GX5ANCNFSM4HW3ICVQ.

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

atomass commented 5 years ago

Hi @AlexeiFedorov I cherry-picked the commit from the official ARM-software repo. This commit should be applied to this Renesas fork as well in order to be able to correctly compile the cert_create tool.

Do you know if Renesas has enabled the secure boot and how to enable it? I found a RCAR_SECURE_BOOT define but no documentation.

AlexeiFedorov commented 5 years ago

I can see Process RCAR_SECURE_BOOT flag ifndef RCAR_SECURE_BOOT RCAR_SECURE_BOOT := 1 endif $(eval $(call add_define,RCAR_SECURE_BOOT)) in plat\renesas\rcar\platform.mk, but my code base is very old as I'm not working with Renesas platforms now.

atomass commented 5 years ago

The thing you posted is the exact thing I was talking about. Not very helpful.