renesas-rz / rzv_drp-ai_tvm

Extension package of Apache TVM (Machine Learning Compiler) for Renesas DRP-AI accelerators powered by Edgecortix MERA(TM) Based Apache TVM version: v0.11.1

Apache License 2.0

44 stars 5 forks source link

Check shape, input on compile_onnx_model.py #23

Open ljkeller opened 4 months ago

ljkeller commented 4 months ago

Summary

On frontend compiler exception, check the input shape and input to improve logging back to user.

This is useful for when users forget to include -s or -i.

Justification

I understand arg_parser.py is convenient common code, but that design prevents checking of required args. Current program failures are not very descriptive for the user. Potentially, the other compile scripts should be updated to check required params as well.

hiroyuki-sakamoto commented 4 months ago

Thank you for your suggestion. Our organization's policy prohibits directly into this repository. Therefore, we will merge your patch into the next release candidate (probably v2.4.0) in our local development repository.

ljkeller commented 4 months ago

Understood.

These policies make me sad! I think my changes could be improved slightly; I might update the PR one last time.