search

reneschubert / keflux

A python package to compute the flux of oceanic kinetic energy across spatial scales from 2D velocity fields at a specific depth using a coarse-graining approach.
MIT License
11 stars 4 forks source link

fix dumdy+dvmdx issue #2

Closed SimonTreillou closed 1 year ago

SimonTreillou commented 1 year ago

I think the second term of $\Pi(L)$ should be (uvm - umvm)(dumdy+dvmdx) instead of (uvm - umvm)(dumdy+dvmdy). I noticed it trying your package for my work on fine scales coastal oceanography. It doesn't seem to change a lot in my results (didn't try it with the data you provide yet), but for what I understand from the theory, it should be the correct implementation and could avoid errors for other users. Thank you for your work, your repo is really nice and it helps me a lot to see what I can use from coarse-graining method in my work !

reneschubert commented 1 year ago

Thank you for making me aware of this typo. You are right, it should be dvdmx and not dvdmy in this part of the equation. I checked and this typo was only present in the version I uploaded to github. It was not present in the analysis routines I used for studies where I cited this package.