reneshbedre / bioinfokit

Bioinformatics data analysis and visualization toolkit
MIT License
334 stars 77 forks source link

Adding the ability to pass an Axes object and DPI value to the maht function. #13

Closed roohy closed 4 years ago

roohy commented 4 years ago

This pull request just adds two simple lines of code. It adds the ability to pass a DPI argument (which is a must for students like me who use your library to draw manuscript figures). It also adds the ability to pass an Axes object; which solves a bunch of problems for me, including setting a DPI and fixing ax titles and ticks. I also added a line to return the Axes object. This is useful for figure manipulation in case the user has not passed an Axes object. When calling the "maht" function, simply pass 'dpi' (ex. dpi=120) and/or an Axes object (ax=ax), obtained by calling the Pyplot's subplots function.

reneshbedre commented 4 years ago

@roohy

Thank you for the PR. The DPI argument is already there in the mhat function which is defined by the r parameter.Additionally, you can also change the axis labels. see docs here https://reneshbedre.github.io/blog/howtoinstall.html#manhatten-plot

roohy commented 4 years ago

Sorry, my bad. I was looking for DPI and I could not find it. Thanks for the awesome library! —

Ruhollah Shemirani

On Aug 26, 2020, at 4:48 PM, Renesh Bedre notifications@github.com wrote:

@roohy https://github.com/roohy Thank you for the PR. The DPI argument is already there in the mhat function which is defined by the r parameter.Additionally, you can also change the axis labels. see docs here https://reneshbedre.github.io/blog/howtoinstall.html#manhatten-plot https://reneshbedre.github.io/blog/howtoinstall.html#manhatten-plot — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/reneshbedre/bioinfokit/pull/13#issuecomment-681180636, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPB7KF46OUAO26F3BDH5DTSCWNMLANCNFSM4QMKRUVA.