search

renettarenula / anchorific.js

⚓️ Generates anchored headings and nested anchored-based navigations based on header tags
MIT License
138 stars 30 forks source link

Local scroll please #3

Closed corysimmons closed 10 years ago

corysimmons commented 10 years ago

Nice plugin. Only suggestion is to add some sort of local scroll bool option. This plugin is a good start: https://github.com/cmpolis/scrollIt.js/ (it works well with your plugin).

renettarenula commented 10 years ago

What exactly is a scroll bool option? Something that allows user to decide whether they want the scrollspy functionality? Let me know.. or you can always send in a pull request. Would definitely want to add features to this plugin. :)

corysimmons commented 10 years ago

Yeah, a true/false so users can decide if they want local scroll (the animation your "Scroll to Top" link does) or not.

Works fine alongside scrollIt and I have a billion things to do so I probably won't be submitting a PR, but kudos on the plugin - I'm going to be using this for jeet.gs soon.

renettarenula commented 10 years ago

You can actually set the 'top' option to 'false' in order to achieve this. Try this and see if it works. Let me know! Thanks! jeet.gs looks awesome. ;)

corysimmons commented 10 years ago

ha, really? Document it. :)

Thanks. Here's the gist of what your plugin is going to look like: http://mojotech.github.io/jeet

renettarenula commented 10 years ago

My bad! Should have document it! Will do soon! Looks awesome, Cory. Good job on the design. Very minimalistic. :)