renevanosnabrugge / vsts-promotepackage-task

Promote a package in VSTS to a Release View
MIT License
21 stars 25 forks source link

Disable manual input on Package field to prevent users from entering a package name since the step only works with package id #10

Closed wouterroos closed 5 years ago

wouterroos commented 5 years ago

Hi,

I noticed that the step works by using the package Id (GUID), but the using the package name in the dropdown combined with allowing manual input suggests that the package can be resolved using the package name which unfortunately is not the case. Ideally I would love to see support for resolving packages by name since this would allow the user to specify the package name before it is present in the feed (my current process first pushes the packages from my artifacts to the feed), a simpeler solution would be to disallow manual input on the picklist to prevent confusion. I think this can be done by setting "EditableOptions": "false" for the package picklist.

renevanosnabrugge commented 5 years ago

Just released 1.2.5 where I set the editable option to false. I understand the need for selecting packages that are not yet in the feed, but this requires more work and time. Pull requests welcome of course!

renevanosnabrugge commented 5 years ago

It was based on your issue, so that might be the cause that you did not see it yet. Fixed it this morning 😊

The easy things don’t take time, Release process is automated 😊

Tx Rene

From: Wouter Roos notifications@github.com Sent: Thursday, December 6, 2018 9:10 AM To: renevanosnabrugge/vsts-promotepackage-task vsts-promotepackage-task@noreply.github.com Cc: Rene van Osnabrugge rvanosnabrugge@live.com; State change state_change@noreply.github.com Subject: Re: [renevanosnabrugge/vsts-promotepackage-task] Disable manual input on Package field to prevent users from entering a package name since the step only works with package id (#10)

Ah great! I didn't see that one yet. Will update asap.

β€” You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frenevanosnabrugge%2Fvsts-promotepackage-task%2Fissues%2F10%23issuecomment-444784244&data=02%7C01%7C%7Cd076e2bf91ea4f3e3a6008d65b523b03%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636796806058191070&sdata=liwX3fflyJq4MBh7kVIalyDAaWXXrDfRIEMbtiTBdnA%3D&reserved=0, or mute the threadhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFx9WjHFX4b-Qd2i_c72OQWzOQShv8Ioks5u2NDbgaJpZM4ZF7Wy&data=02%7C01%7C%7Cd076e2bf91ea4f3e3a6008d65b523b03%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636796806058191070&sdata=snQHTLGE9eCkAmfb%2B0y52Ou5dCRhwAYwF4FmczEe8xE%3D&reserved=0.