renevanosnabrugge / vsts-promotepackage-task

Promote a package in VSTS to a Release View
MIT License
21 stars 25 forks source link

failed to list packages and views in newly created feeds #38

Closed zsw316 closed 4 years ago

zsw316 commented 4 years ago

As far as I know, Microsoft changed the scope of Azure Artifacts feeds from sometime in Nov2019. By default, the newly created feeds are project-scoped, only when the project is made public, its scoped feeds become public.

Details can be seen from https://docs.microsoft.com/en-us/azure/devops/artifacts/feeds/project-scoped-feeds?view=azure-devops

Given that, this task needs to be updated to adapt to that change.

rdayan1 commented 4 years ago

+1

renevanosnabrugge commented 4 years ago

I still see the feed in the project feed. Can you explain a bit more what you mean?

wouterroos commented 4 years ago

Hi,

I'm seeing a similar issue. Newly created feeds are automatically set as 'Project scoped' on creation (I can't seem to find a way to change this). The 'Release Views' dropdown in the step is not populated for these feeds. I also tried to manually enter the name of the desired view instead of selecting it but this causes the following error when executing the release:

System.Net.WebException: The remote server returned an error: (404) Not Found.
   at Microsoft.PowerShell.Commands.WebRequestPSCmdlet.GetResponse(WebRequest request)
   at Microsoft.PowerShell.Commands.WebRequestPSCmdlet.ProcessRecord()at Get-FeedId, D:\a\_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\2.0.5\vsts-promotepackage-task.ps1: line 46
at Set-PackageQuality, D:\a\_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\2.0.5\vsts-promotepackage-task.ps1: line 135
at Run, D:\a\_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\2.0.5\vsts-promotepackage-task.ps1: line 280
at <ScriptBlock>, D:\a\_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\2.0.5\vsts-promotepackage-task.ps1: line 286
at <ScriptBlock>, <No file>: line 1
at <ScriptBlock>, <No file>: line 22
at <ScriptBlock>, <No file>: line 18
at <ScriptBlock>, <No file>: line 1
renevanosnabrugge commented 4 years ago

Is the release views dropdown not populated in the project where the feed is created or another project ?

Verstuurd vanaf mijn iPhone

Op 18 dec. 2019 om 15:37 heeft Wouter Roos notifications@github.com het volgende geschreven:



Hi,

I'm seeing a similar issue. Newly created feeds are automatically set as 'Project scoped' on creation (I can't seem to find a way to change this). The 'Release Views' dropdown in the step is not populated for these feeds. I also tried to manually enter the name of the desired view instead of selecting it but this causes the following error when executing the release:

System.Net.WebException: The remote server returned an error: (404) Not Found. at Microsoft.PowerShell.Commands.WebRequestPSCmdlet.GetResponse(WebRequest request) at Microsoft.PowerShell.Commands.WebRequestPSCmdlet.ProcessRecord()at Get-FeedId, D:\a_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\2.0.5\vsts-promotepackage-task.ps1: line 46 at Set-PackageQuality, D:\a_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\2.0.5\vsts-promotepackage-task.ps1: line 135 at Run, D:\a_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\2.0.5\vsts-promotepackage-task.ps1: line 280 at , D:\a_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\2.0.5\vsts-promotepackage-task.ps1: line 286 at , : line 1 at , : line 22 at , : line 18 at , : line 1

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frenevanosnabrugge%2Fvsts-promotepackage-task%2Fissues%2F38%3Femail_source%3Dnotifications%26email_token%3DABOH2WWB6RIQMDROIG46UG3QZIYR7A5CNFSM4JTPBWY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHGJ4AQ%23issuecomment-567057922&data=02%7C01%7C%7C527edf4cd8da494e9a0a08d783c7c9de%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637122766410697645&sdata=xPghA%2FC9rS0aKkh4Kfkr9u1%2BoJ%2FFf2tWyFe218FDkUY%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABOH2WQQXDSJE5DDR6OSQHLQZIYR7ANCNFSM4JTPBWYQ&data=02%7C01%7C%7C527edf4cd8da494e9a0a08d783c7c9de%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637122766410707656&sdata=qSC1E2XyuLFLUKzBCxhVYM%2FXkoAZUQPEpi86Z6YqqKw%3D&reserved=0.

wouterroos commented 4 years ago

Same project.

renevanosnabrugge commented 4 years ago

Ok. I managed to reproduce the issue. However, I feel it is an issue with the MS task lib. https://github.com/microsoft/azure-pipelines-extensions/blob/master/docs/authoring/endpoints/tfs-vsts-endpoints.md

In the code I refer to "endpointId": "tfs:feed", "endpointUrl": "{{endpoint.url}}/_apis/packaging/feeds",

Endpoint should contain the url with ""project" in it. If this is the case, it all works.. I am raising an issue with MS

renevanosnabrugge commented 4 years ago

https://github.com/microsoft/azure-pipelines-extensions/issues/755

amrock-my commented 4 years ago

Even if the feed url for the task.json was proper, the powershell script does not account for the adjustment in the url.

I created a local (private) copy of the extension for testing and it seems to work, with the exception that the release drop down still does not populate. I'll create a pull request so that the script itself at least works.

amrock-my commented 4 years ago

I'm not sure how to go about contributing my changes, I don't seem to have permissions to create a new branch so that I can make a pull request.

renevanosnabrugge commented 4 years ago

Create a fork and make a PR

Thanks !!

Verstuurd vanaf mijn iPhone

Op 3 jan. 2020 om 15:30 heeft amrock-my notifications@github.com het volgende geschreven:



I'm not sure how to go about contributing my changes, I don't seem to have permissions to create a new branch so that I can make a pull request.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frenevanosnabrugge%2Fvsts-promotepackage-task%2Fissues%2F38%3Femail_source%3Dnotifications%26email_token%3DABOH2WVROWPXTTFOWK4EYSDQ35DWVA5CNFSM4JTPBWY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIBHTZQ%23issuecomment-570587622&data=02%7C01%7C%7C46c030695f35479a2af908d790596c13%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637136586047318200&sdata=Biq9Q8%2BO7zvQ%2Fp7BNh148MHDrMGL0xVdLeR6ZQDUiDY%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABOH2WWWWBKZZU3SZABK7R3Q35DWVANCNFSM4JTPBWYQ&data=02%7C01%7C%7C46c030695f35479a2af908d790596c13%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637136586047328211&sdata=bpwXsyWfv4Lj1%2BrbMDPtmdbKldoXmC5%2BcLLKMDbiszI%3D&reserved=0.

DaRochaRomain commented 4 years ago

I'm still having the issue. Any workaround?

jessehouwing commented 4 years ago

Fixed in the UI now too.

renevanosnabrugge commented 4 years ago

Fixed in https://github.com/renevanosnabrugge/vsts-promotepackage-task/pull/54

wouterroos commented 4 years ago

@renevanosnabrugge Great, thanks!