search

renevanosnabrugge / vsts-promotepackage-task

Promote a package in VSTS to a Release View
MIT License
20 stars 25 forks source link

Support for on-prem TFS #5

Closed dennismi closed 5 years ago

dennismi commented 7 years ago

This should fix #3.

Tested on an actual on-prem TFS (2017.2)

dennismi commented 7 years ago

@renevanosnabrugge had a chance to look it over?

MarkKharitonov commented 5 years ago

Guys, what is the reason not to merge this PR? We need this.

renevanosnabrugge commented 5 years ago

On prem is hard to support for me because I do not have proper ways to test it. Since I have limited time I don’t want to release a buggy task.

I will try to take a look again. All URL’s changed to azure DevOps as well.

You can always fork and release a private task in your own marketplace of course !

Verstuurd vanaf mijn iPhone

Op 5 feb. 2019 om 21:55 heeft MarkKharitonov notifications@github.com<mailto:notifications@github.com> het volgende geschreven:

Guys, what is the reason not to merge this PR? We need this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frenevanosnabrugge%2Fvsts-promotepackage-task%2Fpull%2F5%23issuecomment-460799843&data=02%7C01%7C%7C6a1d154d28cb42f9bd7008d68bac3b9a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636849969176229659&sdata=Y9ENjqS7oL1F7iIj03GQug3YXQATlcwO4uYBsMqjNyA%3D&reserved=0, or mute the threadhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFx9Wk5IRVPtjpwaFZ6jU4rdyisS4PE6ks5vKe-0gaJpZM4PwVP6&data=02%7C01%7C%7C6a1d154d28cb42f9bd7008d68bac3b9a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636849969176239658&sdata=dGRkQJDaNH5o0d%2BV0B4jc%2BiIxuuhzQJopD5QZPrMD%2Fg%3D&reserved=0.

renevanosnabrugge commented 5 years ago

I installed a TFS 2018 and tested the extension with this pull request. It is not working because the endpoints in TFS, the REST API and authentication schemes differ. I will close the issue and will not fix for on-prem. because I cannot test it on the different versions.

MarkKharitonov commented 5 years ago

In that case could you explicitly mention it on the plugin page that it does not support on-premises TFS?

renevanosnabrugge commented 5 years ago

By default this is mentioned on the right side of the marketplace page (works with) but iT might be unclear

I Will update the page

Verstuurd vanaf mijn iPhone

Op 8 feb. 2019 om 01:18 heeft MarkKharitonov notifications@github.com<mailto:notifications@github.com> het volgende geschreven:

In that case could you explicitly mention it on the plugin page that it does not support on-premises TFS?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frenevanosnabrugge%2Fvsts-promotepackage-task%2Fpull%2F5%23issuecomment-461645269&data=02%7C01%7C%7C5437fe15df254b965b7408d68d5af5dc%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636851819143332376&sdata=3B3jkv6cE060ZSfaXA3EZY%2FEhcJkGVNZZzyJa9i3JrQ%3D&reserved=0, or mute the threadhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFx9WrzDa-QgVjwlep59kRBm_X_jsoKcks5vLMJYgaJpZM4PwVP6&data=02%7C01%7C%7C5437fe15df254b965b7408d68d5af5dc%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636851819143342393&sdata=mL2qjLeXfbsn7py5TsQ0bUDVlKdDCNDYjGfsiar25Ww%3D&reserved=0.