Instead of all the wiring that is occurring in the Run cobra command, instead replace the logical parts with a portcullis/application.
Will be able to wire up the logging.Write function to logrus (maybe a portcullis package for logrus?) so that we can maintain all of that.
Logging should be available in the context, so that it is easier to access deeper with the application.
See if we can merge in the configuration file with the overall configuration file via WithConfig(path) option. This allows us to easily update the hcl file without over complicating the minecraft.Server struct (its already getting busy)
RPC should be moved to reading from the config files
minecraft.Server should be registered within the application context.
otel integration should be added
renevo
commented
2 years ago
Instead of all the wiring that is occurring in the Run cobra command, instead replace the logical parts with a portcullis/application.
Will be able to wire up the logging.Write function to logrus (maybe a portcullis package for logrus?) so that we can maintain all of that.
Logging should be available in the context, so that it is easier to access deeper with the application.
See if we can merge in the configuration file with the overall configuration file via WithConfig(path) option. This allows us to easily update the hcl file without over complicating the minecraft.Server struct (its already getting busy)
RPC should be moved to reading from the config files minecraft.Server should be registered within the application context. otel integration should be added