search

renew-js / renew-lib

Core component of renew-js for displaying and modifying drawings
Other
0 stars 0 forks source link

Export module tests are insufficient #100

Closed 0x4d closed 5 years ago

0x4d commented 5 years ago

Describe the bug

Export spec uses expects in event callbacks. The result is that behaviors don't actually need to fire for the tests to succeed.

To Reproduce

Steps to reproduce the behavior:

  1. Comment out call to eventBus.fire()
  2. Tests still run through

Expected behavior

Behavior tests should fail if callback was never called