search

renew-js / renew-lib

Core component of renew-js for displaying and modifying drawings
Other
0 stars 0 forks source link

Simulator initial draft #124

Closed 0x4d closed 5 years ago

0x4d commented 5 years ago

Changes

TODO

codecov[bot] commented 5 years ago

Codecov Report

Merging #124 into master will decrease coverage by 2.02%. The diff coverage is 30.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   65.49%   63.46%   -2.03%     
==========================================
  Files         145      152       +7     
  Lines        1759     1856      +97     
==========================================
+ Hits         1152     1178      +26     
- Misses        607      678      +71
Impacted Files Coverage Δ
src/features/edit/providers/EditProvider.js 100% <ø> (ø) :arrow_up:
src/Simulator.js 100% <ø> (ø) :arrow_up:
src/features/meta-factory/providers/MetaFactory.js 13.04% <ø> (ø) :arrow_up:
src/features/import/providers/Importer.js 81.48% <100%> (ø) :arrow_up:
src/features/move/commands/MoveElementsCommand.js 51.11% <100%> (ø) :arrow_up:
src/features/export/providers/Exporter.js 100% <100%> (ø) :arrow_up:
...xternal-simulation/providers/ExternalSimulation.js 17.14% <17.14%> (ø)
.../simulation-manager/providers/SimulationManager.js 33.33% <33.33%> (ø)
...nal-simulation/behaviors/SimulationStepBehavior.js 66.66% <66.66%> (ø)
...imulation/behaviors/SimulationTerminateBehavior.js 66.66% <66.66%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1df190a...e08ae75. Read the comment docs.

todo[bot] commented 5 years ago

Use Statusbar for this

https://github.com/renew-js/renew-lib/blob/fccb374c21dd5caf049223bf9eede5a4ae380d13/src/features/external-simulation/providers/ExternalSimulation.js#L50-L55

This comment was generated by todo based on a TODO comment in fccb374c21dd5caf049223bf9eede5a4ae380d13 in #124. cc @renew-js.
todo[bot] commented 5 years ago

get default dimensions from somewhere

https://github.com/renew-js/renew-lib/blob/fccb374c21dd5caf049223bf9eede5a4ae380d13/src/features/external-simulation/providers/ExternalSimulation.js#L112-L117

This comment was generated by todo based on a TODO comment in fccb374c21dd5caf049223bf9eede5a4ae380d13 in #124. cc @renew-js.
tim-kilian commented 5 years ago

Set to WIP, util the CI is not green. The merge is missing.

0x4d commented 5 years ago

The PR build passed now, after I removed the cache and restarted it.

tim-kilian commented 5 years ago

Cannot merge it automatically