AnupKM commented 4 years ago

features added:- 1) shape styling 2) text styling 3) preconfigure text style with double click action 4) selection tool extended. Append and remove from selection is possible now.

codecov[bot] commented 4 years ago

Codecov Report

Merging #176 into master will decrease coverage by 10.81%. The diff coverage is 17.22%.

@@             Coverage Diff             @@
##           master     #176       +/-   ##
===========================================
- Coverage   60.81%   50.00%   -10.82%     
===========================================
  Files         158      190       +32     
  Lines        2016     2640      +624     
===========================================
+ Hits         1226     1320       +94     
- Misses        790     1320      +530

Impacted Files	Coverage Δ
src/Modeler.js	`100.00% <ø> (ø)`
src/Viewer.js	`91.66% <ø> (ø)`
src/core/command/Command.js	`100.00% <ø> (ø)`
src/draw/TextRenderer.js	`100.00% <ø> (ø)`
.../fill-opaqueness/commands/FillOpaquenessCommand.js	`0.00% <0.00%> (ø)`
...rc/features/fillcolor/commands/FillColorCommand.js	`0.00% <0.00%> (ø)`
.../features/fillcolor/providers/FillColorProvider.js	`100.00% <ø> (+14.28%)`	:arrow_up:
...rc/features/linewidth/commands/LineWidthCommand.js	`0.00% <0.00%> (ø)`
src/features/meta-tools/MetaContextPad.js	`13.95% <0.00%> (-0.34%)`	:arrow_down:
...es/pen-opaqueness/commands/PenOpaquenessCommand.js	`0.00% <0.00%> (ø)`
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 41d8cb1...ce97311. Read the comment docs.

tim-kilian commented 4 years ago

@AnupKM Can you merge all files?

tim-kilian commented 4 years ago

There seems to be one test failing, can you check this @AnupKM

Firefox 63.0.0 (Linux 0.0.0) modules/edit - Edit Behavior should initialize label at the correct position FAILED

    Expected '13.5' to be '14.75'.

    <Jasmine>

    @webpack:///./test/features/edit/Edit.spec.js?:81:44

    <Jasmine>

Firefox 63.0.0 (Linux 0.0.0): Executed 58 of 181 (1 FAILED) (0 secs / 0.813 secs)

Firefox 63.0.0 (Linux 0.0.0) modules/edit - Edit Behavior should initialize label at the correct position FAILED

    Expected '13.5' to be '14.75'.

    <Jasmine>

    @webpack:///./test/features/edit/Edit.spec.js?:81:44

    <Jasmine>

renew-js / renew-lib

Feature textstyle and shapestyle #176

Codecov Report