search

renew-js / renew-lib

Core component of renew-js for displaying and modifying drawings
Other
0 stars 0 forks source link

Follow MouseEventInit namespace #78

Closed tim-kilian closed 5 years ago

tim-kilian commented 5 years ago

Closes #75

Describe your changes

codecov[bot] commented 5 years ago

Codecov Report

Merging #78 into master will increase coverage by 3.17%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage    60.7%   63.87%   +3.17%     
==========================================
  Files          93       93              
  Lines        1135     1135              
==========================================
+ Hits          689      725      +36     
+ Misses        446      410      -36
Impacted Files Coverage Δ
...features/create/behaviors/CreatePreviewBehavior.js 91.66% <0%> (+8.33%) :arrow_up:
src/features/create/tools/CreateTool.js 52.94% <0%> (+11.76%) :arrow_up:
.../features/create/behaviors/CreateMarkerBehavior.js 38.88% <0%> (+16.66%) :arrow_up:
src/core/toolbox/providers/Toolbox.js 74.07% <0%> (+37.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b038b8a...1062c0d. Read the comment docs.

tim-kilian commented 5 years ago

Followed by this issue I cloned the object before passing it in.

https://github.com/greasemonkey/greasemonkey/issues/1933#issuecomment-46378567

0x4d commented 5 years ago

Did not fix it for me, unfortunately. I don't think it has something to with the MouseEvent parameters. NS_ERROR_FAILURE usually implies that something was not ready yet. As you can't seem to reproduce this error I will try tackling it tomorrow.