search

reneweb / react-native-tensorflow

A TensorFlow inference library for react native
Apache License 2.0
358 stars 59 forks source link

ResourceManager: OkHttpClientProvider.createClient() has been made private #36

Open sometimescasey opened 5 years ago

sometimescasey commented 5 years ago

Hey! Thanks for all the great work.

I'm new to this so please let me know if I've missed something, but when I tried to build this via ./gradlew build I got the following error:

/home/casey/gitrepo/react-native-tensorflow/android/src/main/java/com/rntensorflow/ResourceManager.java:65: 
error: createClient() has private access in OkHttpClientProvider
            Response response = OkHttpClientProvider.createClient().newCall(request).execute();

I assume an update was made that turned the .createClient() method private so I've submitted my resolution in PR #35 but please let me know if there's a better way to address. Thanks again!

reneweb commented 5 years ago

sorry for late reply (haven't checked this one in a while) - not sure why it should not work anymore, but I'll check your pr