search

renezurbruegg / SemanticInstanceFusion

Semantic Instance Fusion for 3D reconstruction of RGB-D indoor images in python
18 stars 2 forks source link

strange axis index in seminstVolume.py #1

Closed GITSHOHOKU closed 3 years ago

GITSHOHOKU commented 3 years ago

Hi, thanks for release this useful repo. I noticed that in SemInstVolume.py line #509 #527 using depth_im by the index [pix_y[valid_pts], pix_y[valid_pts]], should it be exchange x and y coordinate, or is there any detail I missed?

renezurbruegg commented 3 years ago

Hi

The lines you mentioned, do not match with the code snippet. I assume you mean #487 ?

Some of the code comes from andy zengs tsdf-fusion repository. You can find the same line of code there.

Did you try to swap the indices? I think they should match. Note that for opencv images and numpy arrays, x and y are permuted, which can lead to confusing assignments.

GITSHOHOKU commented 3 years ago

Thanks for your reminding. I look through andy zends repository. Your are right, the PIL image.open different from opencv, it's image x-y axis are exchanged.