search

renggli / dart-xml

Lightweight library for parsing, traversing, and transforming XML in Dart.
http://pub.dartlang.org/packages/xml
MIT License
223 stars 52 forks source link

Eliminate dynamic calls #131

Closed srawlins closed 2 years ago

srawlins commented 2 years ago

We've seen dynamic calls adding to binary size. Some come from this package.

These can be statically linted with avoid_dynamic_calls, and then removed.

renggli commented 2 years ago

We probably also have the fix this in https://github.com/renggli/dart-petitparser?

srawlins commented 2 years ago

There is plenty of dynamic in petitparser for sure, but not too much dynamic invocation, I don't think. I do think I saw at least one instance in a recent trace, so I'll be filing a bug there.