search

renkun-ken / formattable

Formattable Data Structures
Other
695 stars 78 forks source link

area() loses formatting #96

Open goreaditya opened 7 years ago

goreaditya commented 7 years ago

I notice that the area function loses the formatting created previously and just displays raw numbers. Is there a way to get more formatting or to retain formatting when using the area function? An example is given below:

transaction <- data.frame(msrp = currency(c(20000.00,24500.00,27700.00),digits=0),sp=currency(c(20000.00,23400.00,26500.00),digits = 0))

formattable(transaction,list(area(col = c("msrp","sp"))~color_tile("white","orange")))

This creates the following table plot 1 The the following code formattable(transaction,list(msrp=color_tile("white","orange"),sp=color_tile("white","orange"))) creates: plot 2

FrankBornais commented 4 years ago

Installing dev version from github solved this issue for me. This has probably been fixed by commit 05587e39aa3a3b466e6eeed80b657948c1c127f2

CRAN's latest version is 0.2.0.1 which has been published on 2016-08-05. The fix was implemented in version in 0.2.0.2 the following day and it looks like it was never sent to CRAN.

@renkun-ken any chance that this old change might someday make its way up to CRAN?

renkun-ken commented 4 years ago

I'll find a time to submit to CRAN recently. Thanks for your reporting!

maximilianmlr commented 2 years ago

Having the same problem. Since i cannot install from Github, could you commit https://github.com/renkun-ken/formattable/commit/05587e39aa3a3b466e6eeed80b657948c1c127f2 so i can install the fix through CRAN?