search

rennat / pynliner

Python CSS-to-inline-styles conversion tool for HTML using BeautifulSoup and cssutils
http://pythonhosted.org/pynliner/
180 stars 93 forks source link

Fix duplicate element issue #51

Closed vil-s closed 7 years ago

vil-s commented 8 years ago

Fixes #49

Simpler solution to the duplicate element issue than the one in #50

tadonis commented 8 years ago

this problem has been fix in my push. #50

vil-s commented 8 years ago

@tadonis yes, I did see that, however I feel that your solution is overly complicated.

Additionally, your pull request seems to try to tackle too many problems at once. In my opinion, your pull request should be two or possibly three separate pull requests; one for the nth-child thing, one for the identical element thing and possibly one for the code reformatting.

rennat commented 7 years ago

Good stuff.