search

renoki-co / blade-mdi

Material Design Icons for Laravel Blade views.
MIT License
4 stars 13 forks source link

Icons don't support filling color #2

Open driesvints opened 4 years ago

driesvints commented 4 years ago

Hi there,

I'm opening this issue because we're currently working on integrating an icon search into the upcoming blade-ui-kit.com website. For this we need to be able to control the look and feel of the icons, especially its color.

It seems that this icon set doesn't supports filling its color yet. For this reason we've currently excluded your icon set from the search. It would be cool if you could fix this so your icon set can also be included in the global search.

Details

Here's an example of your icon missing either fill="none" stroke="currentColor" (outline icons) or fill="currentColor" (solid icons).

How to fix

Apply fill="none" stroke="currentColor" to any outline icons (Heroicons example) or fill="currentColor" to any solid icons (Heroicons example).

Also make sure you remove any attributes that don't belong on the icons like id, class, width & height, etc.

Please respond to this issue as soon as you've been able to fix this and tag a release and we'll include your library in the search.

nuernbergerA commented 4 years ago

You have even more issues.

Current Icon

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" id="mdi-ab-testing" width="24" height="24" viewBox="0 0 24 24">
     <path d="M4 2A2 2 0 0 0 2 4V12H4V8H6V12H8V4A2 2 0 0 0 6 2H4M4 4H6V6H4M22 15.5V14A2 2 0 0 0 20 12H16V22H20A2 2 0 0 0 22 20V18.5A1.54 1.54 0 0 0 20.5 17A1.54 1.54 0 0 0 22 15.5M20 20H18V18H20V20M20 16H18V14H20M5.79 21.61L4.21 20.39L18.21 2.39L19.79 3.61Z" />
</svg>

Drop declaration

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">

Drop id attribute id="mdi-ab-testing"

Good icon

<svg xmlns="http://www.w3.org/2000/svg" fill="currentColor" viewBox="0 0 24 24" stroke="none">
     <path d="M4 2A2 2 0 0 0 2 4V12H4V8H6V12H8V4A2 2 0 0 0 6 2H4M4 4H6V6H4M22 15.5V14A2 2 0 0 0 20 12H16V22H20A2 2 0 0 0 22 20V18.5A1.54 1.54 0 0 0 20.5 17A1.54 1.54 0 0 0 22 15.5M20 20H18V18H20V20M20 16H18V14H20M5.79 21.61L4.21 20.39L18.21 2.39L19.79 3.61Z" />
</svg>
stale[bot] commented 4 years ago

This issue has been automatically closed because it has not had any recent activity. 😨