Closed rennokki closed 3 years ago
Merging #21 (5fb6fa9) into master (bf91616) will decrease coverage by
12.93%
. The diff coverage is75.22%
.
@@ Coverage Diff @@
## master #21 +/- ##
=============================================
- Coverage 89.13% 76.19% -12.94%
Complexity 52 52
=============================================
Files 7 8 +1
Lines 184 189 +5
=============================================
- Hits 164 144 -20
- Misses 20 45 +25
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
src/Console/Commands/InstallCommand.php | 0.00% <0.00%> (ø) |
6.00 <1.00> (+3.00) |
|
src/Http/Controllers/Inertia/BillingController.php | 77.77% <66.66%> (-22.23%) |
3.00 <2.00> (+1.00) |
:arrow_down: |
src/BillingPortal.php | 81.81% <75.00%> (-18.19%) |
5.00 <5.00> (-7.00) |
|
...ttp/Controllers/Inertia/SubscriptionController.php | 83.07% <76.08%> (-16.93%) |
22.00 <14.00> (+2.00) |
:arrow_down: |
...tp/Controllers/Inertia/PaymentMethodController.php | 94.00% <96.15%> (ø) |
10.00 <0.00> (ø) |
|
src/BillingPortalServiceProvider.php | 100.00% <100.00%> (ø) |
3.00 <0.00> (ø) |
|
src/Concerns/ResolvesActions.php | 100.00% <100.00%> (ø) |
1.00 <1.00> (?) |
|
src/Http/Controllers/Inertia/InvoiceController.php | 100.00% <100.00%> (ø) |
2.00 <0.00> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bf91616...5fb6fa9. Read the comment docs.
Renames
The majority of the variables/methods were a mess and didn't reflect the actual meaning for some functions.
getBillableFromRequest
withgetBillable
setBillableOnRequest
withresolveBillable
setStripeCheckoutOptions
withresolveStripeCheckoutOptions
getOptionsForStripeCheckout
withgetStripeCheckoutOptions
onCheckout
withresolveStripeCheckout
onSyncingQuotas
withresolveQuotasSync
Proration between swaps
Proration is enabled by default, but can be overwritten to not prorate between swaps with: