Laravel 10 support - Githubissues

renoki-co / laravel-eloquent-query-cache

Adding cache on your Laravel Eloquent queries' results is now a breeze.

Apache License 2.0

1.04k stars 108 forks source link

Laravel 10 support #174

Closed maciek-szn closed 1 year ago

maciek-szn commented 1 year ago

Looks like Laravel 10 will be released in one week. Are there any chances for update? Thanks! 🙏

szhorvath commented 1 year ago

Yes, please.

tomasbreffitt commented 1 year ago

Was looking into opening a PR, looks like it is dependant on https://github.com/chelout/laravel-relationship-events/pull/56

advil0 commented 1 year ago

Was looking into opening a PR, looks like it is dependant on chelout/laravel-relationship-events#56

Looks like they just released Laravel 10 support! https://github.com/chelout/laravel-relationship-events/releases/tag/v2.0.0

advil0 commented 1 year ago

Looks like it is also dependent on https://github.com/orchestral/database, which says "READ-ONLY", anyone got any ideas?

tomasbreffitt commented 1 year ago

@advil0 I was looking into this, I'm confident that the only orchestral repo needed is testbench, so database and testbench-core can be removed.

I'll have a chance to look at opening a PR in the AM PST, but feel free to beat me to it. Should just require updating dependancies, I believe I did that and tests passed.

advil0 commented 1 year ago

@advil0 I was looking into this, I'm confident that the only orchestral repo needed is testbench, so database and testbench-core can be removed.

I'll have a chance to look at opening a PR in the AM PST, but feel free to beat me to it. Should just require updating dependancies, I believe I did that and tests passed.

Oh neat! I just submitted the PR, it's possible I didn't get something right so feel free to add a comment/etc if something else just needs to be changed.