renoth / factorio-alien-module

A mod for factorio
MIT License
14 stars 16 forks source link

Rampant compatibility: loot not registering #22

Closed bzy-xyz closed 5 years ago

bzy-xyz commented 5 years ago

Rampant 0.16.42 constructs factions in its data-final-fixes.lua, so when loot is registered in data.lua the Rampant enemies don't yet exist. Hence Rampant enemies never drop loot.

Related to but distinct from #8.

(Note: merely renaming data.lua will break e.g. AAI Industry's "Vehicle fuel from alien fuel" recipe.)

renoth commented 5 years ago

Ok so this mod must use final fixes as well. Then soon every mod will have to use final fixes. It would be better to inform rampant mod that their way of modifying biters breaks other mods. I really dont like to support mods abusing the API and forcing this API usage on other mods.

judos commented 4 years ago

Hi @bzy-xyz, did you create a ticket in the rampant mod for this? Or is it fixed there already? I'm interested in starting a new map with both mods... Thanks for your help

bzy-xyz commented 4 years ago

Someone created a compatibility patch: https://mods.factorio.com/mod/rampant-alienmodule-compat

I'd suggest you use that instead of trying to do some sort of ideological warfare.

judos commented 4 years ago

nice that makes me happy that other people already thought of this ^^ Well creating factions in final-fixes is not an ideological discussion but just plain wrong :D but since rampant is not perfectly maintained i won't create an issue there.