renoth / factorio-alien-module

A mod for factorio
MIT License
14 stars 16 forks source link

freezing when levelup #66

Closed Aideln closed 2 months ago

Aideln commented 3 years ago

first time, I think problem in game. but on the third restart, I found out that there was a problem with the mod. It all happened when I leveled up. I don't want to exclude this mod. because it is very nice. I attach a save file and mod list in case it might help.

mods.zip _autosave1.zip

ChildishGiant commented 3 years ago

Is this the same issue as #31?

unhott commented 3 years ago

It appears so. It is worth revisiting if that is still the current behavior.

It is solvable as I demonstrated by using a chunk iterator, guaranteeing 'eventual' upgrade of all entities. I underestimated how many surfaces that some people play with in terms of mods like factorissimo. That is fixable as well by just making a surface iterator, which If I recall correctly I also provided. But I'm not great w/ github so I don't know if it was ever taken seriously.

renoth commented 3 years ago

It only happens on levelup so i think it is tolerable.

HEROgold commented 1 year ago

Well when multiple issues have been reported about the hang, that would tell me that it in fact IS NOT TOLERABLE.

renoth commented 1 year ago

Well when multiple issues have been reported about the hang, that would tell me that it in fact IS NOT TOLERABLE.

Well if the Factorio Developers would provide an API that would solve this issue easily i would have implemented it. If you think it is not tolerable then stop using the mod or provide a pull request.