search

renoth / factorio-factory-levels

MIT License
7 stars 3 forks source link

Productivty from Factories gone? #24

Closed Chaoschaot232 closed 2 years ago

Chaoschaot232 commented 2 years ago

In https://github.com/renoth/factorio-factory-levels/commit/18b39366b054204eb7aee98611b51e481996e94d I have noticed that productivity for assambling machines where removed and I dislike this, if this is intended instead of a bug.

Please re-enable this beavior, otherwise I must fallback to an older version or replace the new code with the old ones.

Furnaces are working fine but Assamblers are not longer having productivity bonuses compared to there level whith which I disagree.

JohnyDL commented 2 years ago

Um a quick code dive (and from running the code in-game) the productivity in assemblers does not appear to have been removed... the code has just been refactored so it's being done by a function with a different name that works on centrifuges and assemblers and furnaces and has the option for even more mod support in the future.

Function is now called -> factory_levels.update_machine_productivity

Chaoschaot232 commented 2 years ago

@JohnyDL I know, since I have also looked this code up but why is it gone for my leveled factories?

Here it should definitly have the Prod-Bar but it's gone: image

Here ist should state the Prod-Factor but it's gone too: image

So smth. went wrong with the migrationsscript and the update.

JohnyDL commented 2 years ago

it's level 16, I think but I'm not certain that productivity is only done in whole numbers of % on the C side of the code (nothing to do with the mod) so level 16 would give a productivity bonus of +0.4% which would round down to 0.

Chaoschaot232 commented 2 years ago

it's level 16, I think but I'm not certain that productivity is only done in whole numbers of % on the C side of the code (nothing to do with the mod) so level 16 would give a productivity bonus of +0.4% which would round down to 0.

That's not correct because in the previous version there was productivity active at this level and it is still active for furnaces:

2% of Productivity applied: image

Productivity Bar: image

And this was also there for the assemblers.

CaitSith2 commented 2 years ago

Now just waiting for @renoth to merge the PR. once back from vacation (or maybe sooner)