definitelytyped including all dependencies

[jfairley]

Recently, I've noticed that my repos have a renovate PR seeming to be grouped as definitelytyped, but the PR seems to include every dependency update that my app needs.

I'm not sure whether this is an issue with the shareable configs or one of my configs, but I'll share some of my configs so we can figure it out...

This worked fine for a long time until recently, and we don't change our config often, which is why I'm suspicious of a shareable config.

---

First, the pull request... 😱

The title here is fix(deps): update definitelytyped.

(Sorry for the low res. Github limits uploaded files to 10MB. It still gets the point across.)

---

Next, an excerpt from my config:

{
  "extends": [
    "config:base",
    "docker:pinDigests",
    "group:recommended",
    "group:reactMonorepo",
    "schedule:weekly"
  ],

  "packageRules": [

    {
      "automerge": true,
      "excludePackageNames": ["@types/react-table"],
      "extends": ["group:definitelyTyped"]
    },

  ]
}

Full config

```json { "extends": [ "config:base", "docker:pinDigests", "group:recommended", "group:reactMonorepo", "schedule:weekly" ], "encrypted": { "npmToken": "-- redacted --" }, "npmrc": "@adcellerant:registry=https://npm.pkg.github.com/\n//npm.pkg.github.com/:_authToken=${NPM_TOKEN}\nalways-auth=true", "commitBody": "[skip release]", "labels": ["dependencies"], "packageRules": [ { "automerge": true, "datasources": ["docker", "orb"], "groupName": "containers" }, { "automerge": true, "depTypeList": ["devDependencies"], "updateTypes": ["minor", "patch", "pin", "digest"] }, { "groupName": "dev-tools", "packageNames": [ "check-node-version", "concurrently", "create-ts-index", "fixpack", "husky", "is-ci", "lint-staged", "nodemon", "prettier", "rimraf", "semantic-release", "ts-node", "wait-on" ], "packagePatterns": ["^@commitlint/", "^@semantic-release/", "webpack"] }, { "automerge": true, "groupName": "cypress", "packageNames": ["cypress"], "packagePatterns": ["^@cypress/", "^cypress-"] }, { "automerge": true, "excludePackageNames": ["@types/react-table"], "extends": ["group:definitelyTyped"] }, { "automerge": true, "groupName": "enzyme", "packageNames": ["enzyme"], "packagePatterns": ["^enzyme-"] }, { "automerge": true, "extends": ["group:fortawesome"] }, { "automerge": true, "groupName": "graphql", "packagePatterns": ["apollo", "graphql"] }, { "automerge": true, "groupName": "jest", "packageNames": ["@types/jest", "jest", "ts-jest"], "packagePatterns": ["^jest-"] }, { "automerge": true, "extends": ["group:linters"] }, { "automerge": true, "groupName": "styled-components", "packagePatterns": ["styled-components"] }, { "automerge": true, "groupName": "supertest", "packageNames": ["supertest"] }, { "automerge": true, "excludePackageNames": ["react-table"], "packageNames": [ "@welldone-software/why-did-you-render", "fast-memoize", "formik", "lodash", "micro-memoize", "moment", "tslib", "typescript", "uuid", "validator", "victory", "w3c-keys", "winston" ], "packagePatterns": ["react"] } ], "separateMultipleMajor": true, "timezone": "America/Denver", "updateNotScheduled": false } ```

---

🤔

[rarkins]

Best if you create a Q&A discussion in the main Renovate repo. The package rule you show here is a config error (by extending group:definitelyTyped you've created a package rule within a package rule) but it seems like it's being interpreted differently now compared to before.

If you're after the quickest fix then it would be to change to this:

    {
      "matchPackagePrefixes": [
        "@types/"
      ],
      "excludePackageNames": ["@types/react-table"],
      "groupName": "definitelyTyped",
      "automerge": true   
    },

Otherwise if you don't mind creating a reproduction repo we can find a better config massaging

[jfairley]

@rarkins, you said Q&A. Is a "discussion" what you're recommending?

[jfairley]

You said Q&A discussion. I think I answered my own question actually.