renovatebot / app-support

Discussion/support issues for the hosted Renovate App
0 stars 0 forks source link

Force pushing commits which modify renovate config should trigger a job #46

Closed ChipWolf closed 4 years ago

ChipWolf commented 4 years ago

What would you like Renovate to be able to do? Renovate should trigger a job if a commit modifying the Renovate config is changed with a force push.

Describe the solution you'd like Currently, only new commits which change the Renovate config appear to trigger an immediate job. I'd like force pushed amended commits to the Renovate config to also trigger a build to assist when debugging changes without creating several new commits.

Describe alternatives you've considered Create several new commits, or dummy changes to the config to trigger a build.

viceice commented 4 years ago

I guess you use the renovate app with github.com ?

That should already work, as renovate app will queue a job run on push. Maybe There is some rate limiting or a already running job.

rarkins commented 4 years ago

What type of "event" does that trigger? We watch for build events:

  } else if (githubEvent === 'push') {
    let allFiles = [];
    if (body.commits) {
      for (const commit of body.commits) {
        allFiles = allFiles
          .concat(commit.added)
          .concat(commit.removed)
          .concat(commit.modified);
      }
    }
    allFiles = [...new Set(allFiles)];
    const modifiedRenovateFiles = allFiles.filter(file =>
      renovateConfigFiles.includes(file)
    );

So if it's not working, either it's a different event to push or the changes do not show up in the committed fields we look at.

ChipWolf commented 4 years ago

Turns out this works as expected after some experimenting.