search

renovatebot / app-support

Discussion/support issues for the hosted Renovate App
0 stars 0 forks source link

Tar file's not being added with offline mirror in yarn #50

Closed kanjieater closed 3 years ago

kanjieater commented 4 years ago

Which Renovate are you using?

WhiteSource Renovate App

Which platform are you using?

GitLab.com

Have you checked the logs? Don't forget to include them if relevant

What would you like to do?

As mentioned here (sorry for posting in the wrong place), I want to be able to have my dependencies updated by renovate, and when a dependency is updated, I want to be able to do an offline install, via yarn install --offline. Therefore, I want to include the tarball that yarn has installed in it's offline mirror directory. https://github.com/renovatebot/renovate/issues/1452

Here's a minimum repository: https://gitlab.com/kanjieater/renovate-test/-/merge_requests/1/diffs

project/.yarnrc:

# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
# yarn lockfile v1

yarn-offline-mirror "./.yarn"
yarn-offline-mirror-pruning true

This is located at the same level as the yarn.lock in the project (project/yarn.lock)

My project/renovate.json looks like this:

{
  "extends": [
    "config:base"
  ],
  "automerge": true,
  "major": {
    "automerge": false
  },
  "rebaseWhen": "behind-base-branch",
}

Tar's are not being committed when Renovate makes it's merge request. The desired outcome is to have the tar's committed alongside the yarn.lock and package.json updates. The pruning is taking effect but not the adding of new tar file.

rarkins commented 4 years ago

Strange, because it works fine from CLI here: https://github.com/renovate-tests/yarn1/pulls

rarkins commented 4 years ago

Exact copy of the repo but renovated using the app reproduces the problem: https://github.com/renovate-tests/yarn2/pull/1/files

rarkins commented 4 years ago

Looks like a problem with Yarn in production - I'll try to solve it soon

kanjieater commented 4 years ago

Sorry to poke, but is there anything I can help with to move this forward? I'd love to help if possible.

rarkins commented 4 years ago

I thought I fixed it at the time. Is the same problem still occurring?

rarkins commented 3 years ago

I'm going to archive this repository so that we have conversations in one place. Therefore please create an "App Support" discussion here if this problem or suggestion is still relevant: https://github.com/renovatebot/renovate/discussions