renovatebot / app-support

Discussion/support issues for the hosted Renovate App
0 stars 0 forks source link

Dashboard not detecting all Gitlab repositories under organization #60

Closed alecgerona closed 4 years ago

alecgerona commented 4 years ago

What Renovate type are you using?

Hosted App with Gitlab

Describe the bug Hi, am trying to install renovate on a private repository on a private organization in Gitlab. I can add renovate bot manually through the members tab but the dashboard can't see the project at all. Or any projects under that directory for that matter. I can add the bot and it made the merge request that starts integration, but the webhook is still missing and it's still absent from the dashboard.

Do I need to do something for the dashboard to view all the repositories?

Relevant debug logs Looking at the api calls the dashboard makes it throws a 404 every other call and the 200s are just OPTIONS calls with no response.

Additional context Looking at the repositories found by the crawl, only those on a specific directory are not being discovered by the dashboard.

rarkins commented 4 years ago

Please provide:

alecgerona commented 4 years ago

Hmm. I'll try to block out the least since these are all private but on the left side menu I see the project that got discovered by the crawler that I added renovate to. When I click the gear it shows every project on every subgroup of our Gitlab organization except for one group.

When I click the gear it starts the search loop and it's mostly 404 except for the one project I have installed renovate on and it never called the projects of the subgroup. I am the owner/admin of the subgroup and the whole organization actually. So this is really weird.

rarkins commented 4 years ago

The client JS first calls "projects?archived=false&min_access_level=40&per_page=100" using your token/identity.

Then for each repository it finds, it checks if Renovate's identity has access. If it doesn't, then there's a 404 response.

It sounds like this might be caused by #35 ?

alecgerona commented 4 years ago

Most probably. We have more than 100 repositories. Can we increase that?

alecgerona commented 4 years ago

As a workaround, is it enough adding the bot manually through the project's members? I successfully received the integration MR. Will merging it add the webhook as well?

rarkins commented 4 years ago

Webhooks can only be added by administrators so we decided not to ask for that permission and have not added the capability on our server side even if given permissions. Hence the only way to add the webhooks is upon login or install for the dashboard, because it's done using your personal oauth token and not stored. I'll look into whether we can handle pagination.

However renovate will still run ~hourly even without webhooks, if you add it as a developer.

alecgerona commented 4 years ago

So I can safely merge the MR for now? The only con is updates run every hour instead of instantly with webhooks? Am I understanding this correctly?

rarkins commented 4 years ago

Yes

alecgerona commented 4 years ago

Great. Thanks. Might as well leave this issue open for when the pagination logic is implemented. Thank you!

rarkins commented 4 years ago

We have #35 so let's close this. Please subscribe to the other