renovatebot / app-support

Discussion/support issues for the hosted Renovate App
0 stars 0 forks source link

Lock file maintenance always outside of schedule #67

Closed dword-design closed 4 years ago

dword-design commented 4 years ago

What Renovate type are you using?

Hosted app GitHub

Describe the bug I have setup Renovate with the default lock file maintenance config:

"lockFileMaintenance": {
    "enabled": true
  }

But it seems that before 5am is never executed according to my logs (see below).

Relevant debug logs See https://app.renovatebot.com/dashboard#github/dword-design/base-config-nuxt

To Reproduce See https://app.renovatebot.com/dashboard#github/dword-design/base-config-nuxt See the renovate config: https://github.com/dword-design/base-config-nuxt/blob/master/.renovaterc.json

rarkins commented 4 years ago

Please copy/paste the relevant sections of the logs here- they are not public. I'm not sure exactly what you mean yet. Eg it's running outside the hours or it's never running?

dword-design commented 4 years ago

Sure. So what's actually relevant aren't the logs but the times of the logs. So now it's 19:44 and we have the times from the screenshots. That's always outside "Mondays before 5am".

Bildschirmfoto 2020-07-20 um 19 44 13
viceice commented 4 years ago

Renovate runs hourly, look at the log details, renovate does nothing outside the schedule

dword-design commented 4 years ago

@viceice But then it should also run before the 12 hours, right? There are no logs in the time where the lock file maintenance is supposed to be done. Or did I miss something?

viceice commented 4 years ago

If you don't configure a timezone renovate will run in UTC.

Also if you check your repo, there is a lockfile maintenance branch. Check the commit time. Should be in schedule.

viceice commented 4 years ago

Also if the lockfile don't change, renovate won't push a lockfile maintenance commit / pr

rarkins commented 4 years ago

I did have an issue with some accounts not running over the weekend which could have stretched into Monday morning. @dword-design if you set "masterIssue": true in your repo then it will give you full visibility into each created or pending PR, and also the possibility to force the PR. So e.g. you could tick the checkbox for lock file maintenance at any time either because you want it out of schedule or if the schedule failed.

dword-design commented 4 years ago

@rarkins This actually pretty much sounds like the issue. Also if I have a look at the log times, there were almost no logs the last two days but 3 days ago there were much more again.

For me it sounds like a bug because with the default values, lock file maintenance should be running on Mondays then.

rarkins commented 4 years ago

Thanks for the confirmation. In that case I'm pretty sure it was an app-specific bug where some repos were not being enqueued. Sorry, but hopefully won't happen again.