renovatebot / config-help

Please use the Discussions feature of https://github.com/renovatebot/renovate instead
https://github.com/renovatebot/renovate/discussions
MIT License
27 stars 16 forks source link

Gradle: bump dependencies and plugins in the same PR #452

Closed gjoseph closed 4 years ago

gjoseph commented 4 years ago

What Renovate type are you using? Self-hosted

Describe the bug

For a build that uses Gradle plugins and libraries/dependencies from the same group, I'd expect a single PR, but I get 3 individual PRs instead, despite having declared a group in renovate.json.

Did you see anything helpful in debug logs?

To Reproduce

Example gradle.build:

plugins {
    id "org.jetbrains.kotlin.jvm" version "1.3.60"
    id "org.jetbrains.kotlin.plugin.spring" version "1.3.60"
}
...
dependencies {
    implementation platform("org.jetbrains.kotlin:kotlin-bom:1.3.60")
}
....

Example renovate.json:


  "extends": [
    "config:base"
  ],
  "reviewers": [
    "hpesojg", ...
  ],
  "reviewersSampleSize": 3,
  "automerge": false,
  "automergeType": "pr",
  "packageRules": [
    {
      "sourceUrlPrefixes": ["https://github.com/JetBrains/kotlin"],
      "groupName": "Kotlin packages"
    }
  ]
}

Additional context

rarkins commented 4 years ago

This config depends on the packages declaring their source repository correctly. If they don’t declare it then the rule won’t apply. Can you switch to using packagePatterns to capture the ones you need?

gjoseph commented 4 years ago

oh duh, yeah that'll probably work. Will reopen if it doesn't. Thanks!!