renovatebot / config-help

Please use the Discussions feature of https://github.com/renovatebot/renovate instead
https://github.com/renovatebot/renovate/discussions
MIT License
27 stars 16 forks source link

autodiscoverFilter for managers #614

Closed augi closed 4 years ago

augi commented 4 years ago

What would you like Renovate to be able to do? It would be great if there was an option for self-hosted deployment that would allow to filter out project based on manager used. Now, it is possible over the project name only (autodiscoverFilter).

Describe the solution you'd like It would be great to have also autodiscoverManagerFilter option.

Additional context The use case in our case is that Scala developers use scala-steward so we would like to skip projects managed by sbt manager, to prevent duplicate PRs.

rarkins commented 4 years ago

Sorry, I don't understand what you need. If you can explain how the existing approaches for enabling and disabling managers doesn't satisfy your requirements, then it would help. For example you could disable the sbt manager in your bot config and any repo that has no other manager files present would be skipped from onboarding.

augi commented 4 years ago

Hello, sorry for my poor English :(

What I want to achieve is to use Renovate in self-hosted deployment (Docker image distribution) and disable sbt manager for all the auto-discovered projects.

So maybe what I need is to setup RENOVATE_ENABLED_MANAGERS environment variable, right? What is please the syntax for definition an array of values when setting this envvar? E.g. gradle,npm?

augi commented 4 years ago

So I think that this issue could be moved to https://github.com/renovatebot/config-help because it seems to be a question now.

It would be great if the self-hosting docs mentioned how to configure the Docker image using environment variables. It seems that all the configs can be set using environment variable prefixed with RENOVATE_. And that syntax for arrays is just comma-separated string. But it's just my guess.

rarkins commented 4 years ago

If you know the full list of enabled managers then that would work, however it could be confusing to your end users if they are wondering why any new manager is disabled.

Maybe easier if we add a disabledManagers option when you only want to disable a small number.

If you use a config.js or config.json in your bot container then you could disable sbt quite easily.

augi commented 4 years ago

Yes, disabledManagers option would be more straightforward for us.

We are using Renovate distributed as Docker image, and run it in k8s. So it is much easier for us to setup all the stuff via environment variables than via a file that has to be mounted etc.

rarkins commented 4 years ago

Another approach which would work right now:

You can configure RENOVATE_ONBOARDING_CONFIG as a JSON string in env.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed soon if no further activity occurs.