renovatebot / config-help

Please use the Discussions feature of https://github.com/renovatebot/renovate instead
https://github.com/renovatebot/renovate/discussions
MIT License
27 stars 16 forks source link

not getting assigned from codeowners #913

Closed evanstoddard23 closed 4 years ago

evanstoddard23 commented 4 years ago

Which Renovate are you using?

WhiteSource Renovate App

Which platform are you using?

GitHub.com

Have you checked the logs? Don't forget to include them if relevant

What would you like to do?

I'd like to get assigned pull request using the relevant code owners if it not auto-mergeable or is and fails status checks. With this config, I never get assigned.

{
  "extends": [
    "config:base",
    ":timezone(America/Chicago)",
    ":semanticCommits"
  ],
  "packageRules": [
    {
      "updateTypes": ["patch"],
      "automerge": true,
      "semanticCommitType": "fix"
    },
    {
      "updateTypes": ["minor"],
      "automerge": true,
      "semanticCommitType": "feat"
    },
    {
      "updateTypes": ["major"],
      "automerge": false,
      "semanticCommitType": "feat"
    }
  ],
  "assigneesFromCodeOwners": true,
  "rebaseWhen": "behind-base-branch",
  "separateMinorPatch": true
}
rarkins commented 4 years ago

Doesn't GitHub auto-assign based on codeowners, or is it only auto-review?

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed soon if no further activity occurs.

evanstoddard23 commented 4 years ago

@rarkins Only auto-review, which is happening.

rarkins commented 4 years ago

Can you set up a public repo with that config to reproduce on a new PR? And does GitHub allow someone to be assignee if they are already auto assigned as reviewer?