Closed mterrel closed 4 years ago
Do you have any tests? When I visit https://gitlab.com/unboundedsystems/adapt/-/merge_requests/377 I see
Renovate won't automerge by default if there's no passing tests
Do you have any tests? When I visit https://gitlab.com/unboundedsystems/adapt/-/merge_requests/377 I see
Renovate won't automerge by default if there's no passing tests
@rarkins Yes, there are tests via GitLab CI. However, due to the secrets required to run the tests, permissions do not allow everyone to access the pipelines or their results, which is why you see Checking pipeline status
. (Aside: I wish it would tell you permission denied.) Since Renovate-bot has Maintainer permissions, I don't believe it will have the same issue.
If you need access to troubleshoot, I can give you that or I can send screen caps or anything else that you need.
That may also explain why https://gitlab.com/api/v4/projects/unboundedsystems%2fadapt/repository/commits/b615faee3e5be81733966259176d5e49962b4495/statuses returned 401. You'll need to troubleshoot this by fetching the result from a status query like this.
@rarkins This merge request just finished all its tests successfully and I believe it should have gotten automerged. I'll leave it in this state for you to look at.
Here's what I see on the MR page:
That may also explain why https://gitlab.com/api/v4/projects/unboundedsystems%2fadapt/repository/commits/b615faee3e5be81733966259176d5e49962b4495/statuses returned 401. You'll need to troubleshoot this by fetching the result from a status query like this.
So I think Renovate-bot is getting this successfully because when I fetch that URL (see contents below), it's an array of 16 entries, one for each CI job. (Each one has status: "success"
.)
And looking in the debug log:
DEBUG: Got res with 16 results(branch="renovate/node-10.x")
I think that's what it's saying: it got 16 status entries.
Here's the output of the URL you gave above:
[{"id":802193841,"sha":"b615faee3e5be81733966259176d5e49962b4495","ref":"renovate/type-name-1.x","status":"success","name":"build:10","target_url":null,"description":null,"created_at":"2020-10-20T18:16:25.272Z","started_at":"2020-10-20T18:16:27.541Z","finished_at":"2020-10-20T18:23:01.755Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802193843,"sha":"b615faee3e5be81733966259176d5e49962b4495","ref":"renovate/type-name-1.x","status":"success","name":"test-cli:10","target_url":null,"description":null,"created_at":"2020-10-20T18:16:25.312Z","started_at":"2020-10-20T18:35:43.254Z","finished_at":"2020-10-20T18:46:38.925Z","allow_failure":false,"coverage":87.16,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802193845,"sha":"b615faee3e5be81733966259176d5e49962b4495","ref":"renovate/type-name-1.x","status":"success","name":"test-cloud:10","target_url":null,"description":null,"created_at":"2020-10-20T18:16:25.327Z","started_at":"2020-10-20T18:36:11.077Z","finished_at":"2020-10-20T18:57:17.880Z","allow_failure":false,"coverage":81.96,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802193846,"sha":"b615faee3e5be81733966259176d5e49962b4495","ref":"renovate/type-name-1.x","status":"success","name":"test-core:10","target_url":null,"description":null,"created_at":"2020-10-20T18:16:25.345Z","started_at":"2020-10-20T18:36:16.558Z","finished_at":"2020-10-20T18:41:33.275Z","allow_failure":false,"coverage":80.24,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802193848,"sha":"b615faee3e5be81733966259176d5e49962b4495","ref":"renovate/type-name-1.x","status":"success","name":"test-systemtest:10","target_url":null,"description":null,"created_at":"2020-10-20T18:16:25.361Z","started_at":"2020-10-20T18:36:20.456Z","finished_at":"2020-10-20T18:51:01.502Z","allow_failure":false,"coverage":0.0,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802193849,"sha":"b615faee3e5be81733966259176d5e49962b4495","ref":"renovate/type-name-1.x","status":"success","name":"test-other:10","target_url":null,"description":null,"created_at":"2020-10-20T18:16:25.377Z","started_at":"2020-10-20T18:37:12.786Z","finished_at":"2020-10-20T18:39:53.612Z","allow_failure":false,"coverage":63.19,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802193850,"sha":"b615faee3e5be81733966259176d5e49962b4495","ref":"renovate/type-name-1.x","status":"success","name":"test-cli:12","target_url":null,"description":null,"created_at":"2020-10-20T18:16:25.393Z","started_at":"2020-10-20T18:37:29.077Z","finished_at":"2020-10-20T18:47:43.311Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802193851,"sha":"b615faee3e5be81733966259176d5e49962b4495","ref":"renovate/type-name-1.x","status":"success","name":"test-cloud:12","target_url":null,"description":null,"created_at":"2020-10-20T18:16:25.411Z","started_at":"2020-10-20T18:37:47.945Z","finished_at":"2020-10-20T18:46:57.439Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802193853,"sha":"b615faee3e5be81733966259176d5e49962b4495","ref":"renovate/type-name-1.x","status":"success","name":"test-core:12","target_url":null,"description":null,"created_at":"2020-10-20T18:16:25.428Z","started_at":"2020-10-20T18:37:48.717Z","finished_at":"2020-10-20T18:42:17.566Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802193855,"sha":"b615faee3e5be81733966259176d5e49962b4495","ref":"renovate/type-name-1.x","status":"success","name":"test-systemtest:12","target_url":null,"description":null,"created_at":"2020-10-20T18:16:25.451Z","started_at":"2020-10-20T18:38:25.312Z","finished_at":"2020-10-20T18:50:42.670Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802193856,"sha":"b615faee3e5be81733966259176d5e49962b4495","ref":"renovate/type-name-1.x","status":"success","name":"test-other:12","target_url":null,"description":null,"created_at":"2020-10-20T18:16:25.469Z","started_at":"2020-10-20T18:38:37.096Z","finished_at":"2020-10-20T18:41:30.905Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802193857,"sha":"b615faee3e5be81733966259176d5e49962b4495","ref":"renovate/type-name-1.x","status":"success","name":"test-cli:14","target_url":null,"description":null,"created_at":"2020-10-20T18:16:25.484Z","started_at":"2020-10-20T18:38:57.355Z","finished_at":"2020-10-20T18:48:37.377Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802193858,"sha":"b615faee3e5be81733966259176d5e49962b4495","ref":"renovate/type-name-1.x","status":"success","name":"test-cloud:14","target_url":null,"description":null,"created_at":"2020-10-20T18:16:25.498Z","started_at":"2020-10-20T18:39:12.676Z","finished_at":"2020-10-20T18:49:00.087Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802193859,"sha":"b615faee3e5be81733966259176d5e49962b4495","ref":"renovate/type-name-1.x","status":"success","name":"test-core:14","target_url":null,"description":null,"created_at":"2020-10-20T18:16:25.512Z","started_at":"2020-10-20T18:39:39.256Z","finished_at":"2020-10-20T18:44:43.707Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802193860,"sha":"b615faee3e5be81733966259176d5e49962b4495","ref":"renovate/type-name-1.x","status":"success","name":"test-systemtest:14","target_url":null,"description":null,"created_at":"2020-10-20T18:16:25.529Z","started_at":"2020-10-20T18:39:56.539Z","finished_at":"2020-10-20T18:51:55.846Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802193861,"sha":"b615faee3e5be81733966259176d5e49962b4495","ref":"renovate/type-name-1.x","status":"success","name":"test-other:14","target_url":null,"description":null,"created_at":"2020-10-20T18:16:25.545Z","started_at":"2020-10-20T18:40:38.141Z","finished_at":"2020-10-20T18:43:23.677Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}}]
Here's the status for the latest commit on merge request 376 for @types/numeral
.
[{"id":802328789,"sha":"f3c92e1e514f3835ed01d2d4b631a6b8e1b8bc14","ref":"renovate/numeral-0.x","status":"success","name":"build:10","target_url":null,"description":null,"created_at":"2020-10-20T19:17:18.756Z","started_at":"2020-10-20T19:17:22.364Z","finished_at":"2020-10-20T19:22:27.815Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802328792,"sha":"f3c92e1e514f3835ed01d2d4b631a6b8e1b8bc14","ref":"renovate/numeral-0.x","status":"success","name":"test-cli:10","target_url":null,"description":null,"created_at":"2020-10-20T19:17:18.800Z","started_at":"2020-10-20T19:25:10.591Z","finished_at":"2020-10-20T19:35:48.495Z","allow_failure":false,"coverage":87.16,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802328794,"sha":"f3c92e1e514f3835ed01d2d4b631a6b8e1b8bc14","ref":"renovate/numeral-0.x","status":"success","name":"test-cloud:10","target_url":null,"description":null,"created_at":"2020-10-20T19:17:18.823Z","started_at":"2020-10-20T19:25:11.020Z","finished_at":"2020-10-20T19:46:49.306Z","allow_failure":false,"coverage":81.96,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802328795,"sha":"f3c92e1e514f3835ed01d2d4b631a6b8e1b8bc14","ref":"renovate/numeral-0.x","status":"success","name":"test-core:10","target_url":null,"description":null,"created_at":"2020-10-20T19:17:18.843Z","started_at":"2020-10-20T19:25:14.031Z","finished_at":"2020-10-20T19:30:25.410Z","allow_failure":false,"coverage":80.24,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802328797,"sha":"f3c92e1e514f3835ed01d2d4b631a6b8e1b8bc14","ref":"renovate/numeral-0.x","status":"success","name":"test-systemtest:10","target_url":null,"description":null,"created_at":"2020-10-20T19:17:18.868Z","started_at":"2020-10-20T19:25:39.234Z","finished_at":"2020-10-20T19:40:51.411Z","allow_failure":false,"coverage":0.0,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802328799,"sha":"f3c92e1e514f3835ed01d2d4b631a6b8e1b8bc14","ref":"renovate/numeral-0.x","status":"success","name":"test-other:10","target_url":null,"description":null,"created_at":"2020-10-20T19:17:18.896Z","started_at":"2020-10-20T19:25:57.951Z","finished_at":"2020-10-20T19:28:45.370Z","allow_failure":false,"coverage":63.19,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802328801,"sha":"f3c92e1e514f3835ed01d2d4b631a6b8e1b8bc14","ref":"renovate/numeral-0.x","status":"success","name":"test-cli:12","target_url":null,"description":null,"created_at":"2020-10-20T19:17:18.919Z","started_at":"2020-10-20T19:26:13.044Z","finished_at":"2020-10-20T19:35:34.998Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802328803,"sha":"f3c92e1e514f3835ed01d2d4b631a6b8e1b8bc14","ref":"renovate/numeral-0.x","status":"success","name":"test-cloud:12","target_url":null,"description":null,"created_at":"2020-10-20T19:17:18.946Z","started_at":"2020-10-20T19:27:02.430Z","finished_at":"2020-10-20T19:36:07.334Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802328805,"sha":"f3c92e1e514f3835ed01d2d4b631a6b8e1b8bc14","ref":"renovate/numeral-0.x","status":"success","name":"test-core:12","target_url":null,"description":null,"created_at":"2020-10-20T19:17:18.964Z","started_at":"2020-10-20T19:27:17.464Z","finished_at":"2020-10-20T19:31:43.991Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802328807,"sha":"f3c92e1e514f3835ed01d2d4b631a6b8e1b8bc14","ref":"renovate/numeral-0.x","status":"success","name":"test-systemtest:12","target_url":null,"description":null,"created_at":"2020-10-20T19:17:18.987Z","started_at":"2020-10-20T19:27:22.957Z","finished_at":"2020-10-20T19:39:30.716Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802328809,"sha":"f3c92e1e514f3835ed01d2d4b631a6b8e1b8bc14","ref":"renovate/numeral-0.x","status":"success","name":"test-other:12","target_url":null,"description":null,"created_at":"2020-10-20T19:17:19.002Z","started_at":"2020-10-20T19:27:39.558Z","finished_at":"2020-10-20T19:30:01.177Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802328811,"sha":"f3c92e1e514f3835ed01d2d4b631a6b8e1b8bc14","ref":"renovate/numeral-0.x","status":"success","name":"test-cli:14","target_url":null,"description":null,"created_at":"2020-10-20T19:17:19.017Z","started_at":"2020-10-20T19:28:19.652Z","finished_at":"2020-10-20T19:37:48.289Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802328812,"sha":"f3c92e1e514f3835ed01d2d4b631a6b8e1b8bc14","ref":"renovate/numeral-0.x","status":"success","name":"test-cloud:14","target_url":null,"description":null,"created_at":"2020-10-20T19:17:19.034Z","started_at":"2020-10-20T19:28:46.809Z","finished_at":"2020-10-20T19:38:39.785Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802328815,"sha":"f3c92e1e514f3835ed01d2d4b631a6b8e1b8bc14","ref":"renovate/numeral-0.x","status":"success","name":"test-core:14","target_url":null,"description":null,"created_at":"2020-10-20T19:17:19.049Z","started_at":"2020-10-20T19:30:03.642Z","finished_at":"2020-10-20T19:34:35.120Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802328817,"sha":"f3c92e1e514f3835ed01d2d4b631a6b8e1b8bc14","ref":"renovate/numeral-0.x","status":"success","name":"test-systemtest:14","target_url":null,"description":null,"created_at":"2020-10-20T19:17:19.064Z","started_at":"2020-10-20T19:30:26.985Z","finished_at":"2020-10-20T19:42:33.474Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}},{"id":802328818,"sha":"f3c92e1e514f3835ed01d2d4b631a6b8e1b8bc14","ref":"renovate/numeral-0.x","status":"success","name":"test-other:14","target_url":null,"description":null,"created_at":"2020-10-20T19:17:19.082Z","started_at":"2020-10-20T19:31:02.717Z","finished_at":"2020-10-20T19:33:44.813Z","allow_failure":false,"coverage":null,"author":{"id":1263493,"name":"WhiteSource Renovate","username":"renovate-bot","state":"active","avatar_url":"https://assets.gitlab-static.net/uploads/-/system/user/avatar/1263493/avatar.png","web_url":"https://gitlab.com/renovate-bot"}}]
@rarkins Merge request 376 just suddenly automerged after sitting there for at least 37 minutes in a ready-to-merge state (at least as far as I could tell). I didn't change anything and I'm not immediately seeing anything that happened to trigger it (like perhaps a recently-finished CI run on some other branch or...?).
Did you do anything or did I just need to wait for some time to pass before it would automerge? Could this possibly be related to prHourlyLimit
? My understanding from the docs is that prHourlyLimit
limits the creation of PRs, not the merging of PRs?
It's working as expected. Automerges are performed whenever Renovate runs, not instantly.
What Renovate type, platform and version are you using?
Hosted Renovate on GitLab
Describe the bug
Automerge is not working for our open source project, AdaptJS on GitLab. The debug logs indicate that the branch status is yellow, but there's not enough information to figure out what to examine next to troubleshoot.
So the primary request here is for more detailed information on what might be keeping the branch from being automerged. Assuming that the
branchStatus: yellow
is what's keeping the branch from being merged, either a text description of what items might causebranchStatus: yellow
would work or also more info in the debug log as to what exactly caused that condition.Relevant debug logs
This debug log shows a branch (branch =
renovate/node-10.x
) that I believe should have been automerged, but was not.The relevant portion seems to be:
To Reproduce
I realize the existing open source repo isn't minimal, but it is public and does repro the issue. I'm happy to make changes to help troubleshoot the issue.
Additional context
The merges are to
master
, which is a protected branch, but Renovate-bot has Maintainer permissions.