renovatebot / config-help

Please use the Discussions feature of https://github.com/renovatebot/renovate instead
https://github.com/renovatebot/renovate/discussions
MIT License
27 stars 16 forks source link

Cannot merge some patch dependencies #974

Closed fclairamb closed 3 years ago

fclairamb commented 4 years ago

WhiteSource Renovate App

Which platform are you using?

GitHub.com

Have you checked the logs? Don't forget to include them if relevant

Yes you can find them here: https://app.renovatebot.com/dashboard#github/habx/ui-table/259137788

What would you like to do?

I'd like to automatically merge all patch dependencies (except one). It works fine on other repositories but not on this one and I don't get why:

The following config defines contains this packageRule:

    {
      "updateTypes": [
        "patch"
      ],
      "depTypeList": [
        "dependencies",
        "peerDependencies"
      ],
      "automerge": true,
      "labels": [
        "habx-automerge"
      ]
    },

But then for this PR I will get the following PR status:

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

And the logs show something even stranger:

        "deps": [
          {
            "depType": "dependencies",
            "depName": "@testing-library/react",
            "currentValue": "^11.1.1",
            "datasource": "npm",
            "prettyDepType": "dependency",
            "lockedVersion": "11.1.1",
            "depIndex": 0,
            "warnings": [],
            "fixedVersion": "11.1.1",
            "sourceUrl": "https://github.com/testing-library/react-testing-library",
            "updates": [
              {
                "fromVersion": "11.1.1",
                "toVersion": "11.1.2",
                "newValue": "^11.1.2",
                "newMajor": 11,
                "newMinor": 1,
                "updateType": "minor",
                "isSingleVersion": false,
                "isRange": true,
                "releaseTimestamp": "2020-11-11T09:05:57.624Z",
                "canBeUnpublished": true,
                "isBump": true
              }
            ]
          }
   ]

Which I suspect is the source of the issue because it shows "updateType": "minor" when it seems it should set to patch.

Can you help me figure this out?

rarkins commented 4 years ago

Add separateMinorPatch=true to your config

viceice commented 4 years ago

https://docs.renovatebot.com/configuration-options/#separateminorpatch

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed soon if no further activity occurs. If this question is not done (either you plan to update it or are waiting on someone to respond) then please add a comment here to bump it and/or get the other person's attention. We aim to do our best to solve every problem. This bot is here to help us clean up issues which are no longer of use to the original poster, and not to close anything prematurely, so bump as you need!