search

renovatebot / github-action

Other
267 stars 80 forks source link

Custom checkbox resets renovate PR #861

Closed stefanochang closed 3 weeks ago

stefanochang commented 3 weeks ago

Goal

Our goal at Turo is to extend the renovatebot generated PR by appending a set of checkboxes in the PR footer, these custom checkboxes would be managed by checkmate to ensure they are not ignored by the developers. We have the default settings for the renovatebot rebase operation, and the bottom snippet of our PR description looks like this 

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

Sandboxes (select 1)

<!--Checkmate select=1-->
- [ ] These changes do not affect sandboxes
- [ ] I have tested my changes in a sandbox: PASTE YOUR SBX PR HERE
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNTkuNyIsInVwZGF0ZWRJblZlciI6IjM1LjE1OS43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Problem

We have successfully added the checkboxes to the footer, however the problem we're seeing is when a developer checks our custom checkboxes, it triggers renovate bot to regenerate the description (screenshot below shows to demonstrate action that triggers PR regeneration)

Screenshot 2024-08-19 at 6 10 05 PM

Desired Behavior

The desired behavior is that renovate bot will not regenerate the PR if the checkboxes checked were not created by renovatebot, looking at the code it appears that the intention was for renovatebot to only rebase if the rebase specific checkbox was checked, specifically this prefix

 <!-- rebase-check -->
viceice commented 3 weeks ago

wrong repo, please open a new discussion on main renovate repo.