renovatebot / renovate

Home of the Renovate CLI: Cross-platform Dependency Automation by Mend.io
https://mend.io/renovate
GNU Affero General Public License v3.0
17.42k stars 2.29k forks source link

Use better monorepo names in `monorepo.ts` #10210

Closed HonkingGoose closed 3 years ago

HonkingGoose commented 3 years ago

What would you like Renovate to be able to do?

I made a PR to add a new monorepo to the list, and saw that @viceice changed the name of the repo from fontsource -> Fontsource. But other names in this list use lowercase, so we're not consistent with capitalization of the mono repo names.

I'd like to use proper names and make things consistent again, but that's a potentially breaking change. 😄

Did you already have any implementation ideas?

I'd like some feedback from the Renovate team on what the proper names are, and if we want this change at all. 😄

If I know what we want, and if we want it, I'll then make a draft PR with the breaking label.

viceice commented 3 years ago

We should check the spelling on target repos. Some monorepos are correct in lowercase.

HonkingGoose commented 3 years ago

We should check the spelling on target repos

Agree, the spelling should be correct at least. 😄

Some monorepos are correct in lowercase.

How do we choose between lowercase and Capitalized name? Do we look at how the repository capitalizes their "brand name", or how it's used on their website?


@rarkins What do you think of this idea? Do you have input/ideas/wishes?

viceice commented 3 years ago

I mostly take their "brand name".

https://github.com/renovatebot/renovate/blob/3a1980811c335edaaee8814f9b54fd34851a5ee5/lib/config/presets/internal/group.ts#L116-L116

Maybe it's better to only use lowercase? But for sure we should force some consistency.

viceice commented 3 years ago

@rarkins This rule is missing the group name? https://github.com/renovatebot/renovate/blob/3a1980811c335edaaee8814f9b54fd34851a5ee5/lib/config/presets/internal/group.ts#L129-L138

So here we use the monorepo name as preset name, so we should go to lowercase without spaces. https://github.com/renovatebot/renovate/blob/3a1980811c335edaaee8814f9b54fd34851a5ee5/lib/config/presets/internal/group.ts#L581-L591

HonkingGoose commented 3 years ago

Hi @rarkins, can you provide some feedback on the things discussed above?

rarkins commented 3 years ago

I prefer lower case without spaces where possible

HonkingGoose commented 3 years ago

@rarkins Shall I make a PR that checks the spelling and uses lowercase throughout? Any exceptions to the rule can then be changed in the PR by you. 😄

rarkins commented 3 years ago

I don't think we need to automate this one, unless @viceice thinks so

HonkingGoose commented 3 years ago

I don't think we need to automate this one, unless @viceice thinks so

Oh maybe I'm confusing things here by talking about exceptions to rules. I'm not writing code to automate this change. 😉

I'm thinking of manually adjusting the monorepo names so that they all use "lowercase without spaces".

Did you mean that you don't really care about the naming?

rarkins commented 3 years ago

Changing to lower-case is OK, but branch names will change unless the spaces are replaced by hyphens -, and we'd like to avoid that unnecessarily.

HonkingGoose commented 3 years ago

We fixed the monorepo names on the v26 version of Renovate, so this issue can be closed.

Related PRs: