Using relative path in .gitsubmodule leads to random errors #10655

Closed damoon closed 11 months ago

How are you running Renovate?

[ ] WhiteSource Renovate hosted app on github.com
[x] Self hosted

If using the hosted app, please skip to the next section. Otherwise, if self-hosted, please complete the following:

Please select which platform you are using:

[ ] Azure DevOps (dev.azure.com)
[ ] Azure DevOps Server
[ ] Bitbucket Cloud (bitbucket.org)
[ ] Bitbucket Server
[ ] Gitea
[ ] github.com
[ ] GitHub Enterprise Server
[x] gitlab.com
[ ] GitLab self-hosted

Renovate version: v25.51.5

Describe the bug

I use a relative path in .gitsubmodules. I needs this so that ci pipelines can clone via http and i can pull and push via ssh.

Sometimes renovate just ignores all submodules updates and does not show an error. Sometimes renovate shows this warning but creates a MR with the update for an other module. Sometimes renovate shows an error and does not create a MR.

Relevant debug logs

 WARN: Error mapping git submodules during extraction (repository=utopia-planitia/test-infra/integration-cluster)
       "err": {
         "task": {
           "commands": ["ls-remote", "--symref", "https:///ci/nexus.git", "HEAD"],
           "format": "utf-8"
         },
         "message": "fatal: unable to access 'https:///ci/nexus.git/': Could not resolve host: ci\n",
         "stack": "Error: fatal: unable to access 'https:///ci/nexus.git/': Could not resolve host: ci\n\n    at Object.action (/usr/src/app/node_modules/simple-git/src/lib/plugins/error-detection.plugin.ts:38:28)\n    at PluginStore.exec (/usr/src/app/node_modules/simple-git/src/lib/plugins/plugin-store.ts:24:29)\n    at /usr/src/app/node_modules/simple-git/src/lib/runners/git-executor-chain.ts:114:40\n    at new Promise (<anonymous>)\n    at GitExecutorChain.handleTaskData (/usr/src/app/node_modules/simple-git/src/lib/runners/git-executor-chain.ts:111:14)\n    at GitExecutorChain.<anonymous> (/usr/src/app/node_modules/simple-git/src/lib/runners/git-executor-chain.ts:88:40)\n    at Generator.next (<anonymous>)\n    at fulfilled (/usr/src/app/node_modules/simple-git/src/lib/runners/git-executor-chain.js:5:58)\n    at processTicksAndRejections (internal/process/task_queues.js:95:5)"
       }

Have you created a minimal reproduction repository?

https://gitlab.com/utopia-planitia/test-infra/integration-cluster/-/blob/main/.gitmodules

[ ] I have provided a minimal reproduction repository
[x] I don't have time for that, but it happens in a public repository I have linked to
[ ] I don't have time for that, and cannot share my private repository
[ ] The nature of this bug means it's impossible to reproduce publicly

Hi @damoon, thank you for opening a issue. Can you please copy/paste our issue template and fill it in?

done :D

Oh you can remove this part, as we don't need it. Those things only work when the issue is opened first.

---
name: Bug report
about: You've found a bug with Renovate
labels: 'type:bug, status:requirements, priority-5-triage'
---

@JamieMagee can you look at this? Seems like we're not doing enough input validation.

Sure. I think we should be dealing with this case here:

https://github.com/renovatebot/renovate/blob/cb752dbee95575954469d071fdcddde71d6d806b/lib/manager/git-submodules/extract.ts#L25-L31

It looks like in https:///ci/nexus.git is an alias. @damoon Do you run Renovate on gitlab CI? If so, could you share a link to a run?

here are the full debug logs https://gitlab.com/utopia-planitia/test-infra/renovate-bot/-/jobs/1388050858

in this setup i use main instead of master as the default branch. after explicitly defining main as the remote branch (instead of relying on HEAD) this bug does not happen to me anymore. https://gitlab.com/utopia-planitia/test-infra/integration-cluster/-/commit/db8a76888600ff69da2af10eec3278f849b4e7db

maybe a more descriptive error message mentioning this behavior would be nice.

I'm not sure exactly what is the problem/limitation though

i use main as the primary branch name. once i started to mentions this in the .gitmodules file the error did not show again.

i assume somewhere master is used to search for updates.

Hi there,

Get your issue fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the issue if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

renovatebot / renovate

Using relative path in .gitsubmodule leads to random errors #10655