search

renovatebot / renovate

Home of the Renovate CLI: Cross-platform Dependency Automation by Mend.io
https://mend.io/renovate
GNU Affero General Public License v3.0
16.82k stars 2.2k forks source link

Renovate spam GitHub issues #10902

Closed oliviertassinari closed 3 years ago

oliviertassinari commented 3 years ago

If using the hosted app, please skip to the next section. Otherwise, if self-hosted, please complete the following:

Please select which platform you are using:

Renovate version: any

Describe the bug

Renovate opens pull requests linking the PRs on the changelog without any proxies. This makes the work of the maintainers harder. We can no longer easily find all the related effort to a given issue.

Have you created a minimal reproduction repository?

See https://github.com/mui-org/material-ui/issues/27170

Capture d’écran 2021-07-20 à 12 34 21
rarkins commented 3 years ago

Strange - must be a pattern which our sanitizers miss. Also strange that it's an open issue being referenced in a changelog. We need to locate the backlink in the PRs, then locate the raw changelog it's derived from, and then fix our sanitisation.

oliviertassinari commented 3 years ago

@rarkins I assume it's because of this link in the changelog: https://github.com/mui-org/material-ui/blame/next/CHANGELOG.md#L16

rarkins commented 3 years ago

@zharinov Could you take a look?

zharinov commented 3 years ago

@zharinov Could you take a look?

Okay

rarkins commented 3 years ago

Please test in private repos so that we don't increase the back links any further. I know if you delete a link then the backlink still remains, although maybe if you delete the whole repo then it disappears.

zharinov commented 3 years ago

Yes, the whole repo deletion works, while link deletion isn't

rarkins commented 3 years ago

Maybe the "." at the end of that link fools the linkify we use? There just be something special about that link because the others seem fine and we haven't had a link spam complaint in at least a year

zharinov commented 3 years ago

Hi @oliviertassinari, did you notice another occurrences of this bug for other issues? We think it has something to do with markdown parsing of particular line you mentioned in the CHANGELOG.md.

oliviertassinari commented 3 years ago

Not I can think of. Happy to hear that it's an isolated/edge-case issue.

renovate-release commented 3 years ago

:tada: This issue has been resolved in version 25.69.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

oliviertassinari commented 3 years ago

Thanks for the fix

rarkins commented 3 years ago

We need to unfortunately reopen this due to a regression error causing mui/material-ui#11133 to be reverted

renovate-release commented 3 years ago

:tada: This issue has been resolved in version 25.72.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: