rarkins
commented
2 years ago Does it do the same if you put extends config in the repo instead?
Open astellingwerf opened 2 years ago
rarkins
commented
2 years ago Does it do the same if you put extends config in the repo instead?
astellingwerf
commented
2 years ago No it still splits incorrectly then:
DEBUG: packageFiles with updates (repository=astellingwerf/reproduce-renovate-discussion-11438)
"config": {
"npm": [
{
"packageFile": "package.json",
"deps": [
{
"depType": "dependencies",
"depName": "@angular/core",
"currentValue": "~11.1.0",
"datasource": "npm",
"prettyDepType": "dependency",
"lockedVersion": "11.1.2",
"depIndex": 0,
"updates": [
{
"updateType": "pin",
"isPin": true,
"newValue": "11.1.2",
"newMajor": 11,
"branchName": "renovate/angular-monorepo"
},
{
"bucket": "non-major",
"newVersion": "11.2.14",
"newValue": "11.2.14",
"releaseTimestamp": "2021-05-12T21:17:07.664Z",
"newMajor": 11,
"newMinor": 2,
"updateType": "minor",
"branchName": "renovate/angular-monorepo"
},
{
"bucket": "major",
"newVersion": "12.2.5",
"newValue": "12.2.5",
"releaseTimestamp": "2021-09-08T16:33:48.312Z",
"newMajor": 12,
"newMinor": 2,
"updateType": "major",
"branchName": "renovate/major-angular-monorepo"
}
],
...So can you get it to reproduce on github.com using the hosted app?
astellingwerf
commented
2 years ago 
renovate-release
commented
2 years ago :tada: This issue has been resolved in version 27.4.2 :tada:
The release is available on:
27.4.2Your semantic-release bot :package::rocket:
astellingwerf
commented
2 years ago In a version from this weekend, this issue is not fixed for all pinning. For example, Font Awesome dependencies like "@fortawesome/react-fontawesome": "^0.1.4" are still put in a separate branch (see https://github.com/astellingwerf/renovate-issue-11680/issues/17).
MaronHatoum
commented
1 year ago Hi @astellingwerf I tried to reproduce the issue with Renovate's latest release, I would like to share with you the PRs that Renovate created to make sure if the issue has been fixed, from my perspective I can see that the issue is disappeared: https://github.com/MaronHatoum/renovate-issue-11680/pulls
astellingwerf
commented
1 year ago Is pinning enabled though?
MaronHatoum
commented
1 year ago @astellingwerf I ran Renovate one more time with rangeStrategy = pin
this is the result: https://github.com/MaronHatoum/renovate-issue-11680/pulls
astellingwerf
commented
1 year ago I still see this in Renovate 32.151.2:
I'd need to look into it further, but from what I seem to recall, it seems that groups have an impact on this. Can you check that (in this case) the group:fortawesome preset is part of your configuration?
MaronHatoum
commented
1 year ago @astellingwerf this is the configuration I'm using:
"config": {
"token": "***********",
"platform": "github",
"onboardingConfig": {"extends": []},
"prConcurrentLimit": 0,
"branchConcurrentLimit": 0,
"onboarding": true,
"logContext": "json",
"logFileLevel": "debug",
"logFile": "/tmp/log.json",
"dependencyDashboard": true,
"includeForks": true,
"ignoreUnstable": false,
"rangeStrategy": "pin",
"repositories": ["MaronHatoum/renovate-issue-11680"],
"gitAuthor": "Self-hosted Renovate Bot <email@email.com>",
"assignees": ["maron"]
}And using the debugger I checked config.packageRules and I saw that it is empty
rarkins
commented
1 year ago If this is a reproduction then config like rangeStrategy should be in the repo config and not config.js
MaronHatoum
commented
1 year ago You are right rangeStartegy exists in repo config
I added it to config.js just to make it clear that I'm using this configuration.
github-actions[bot]
commented
1 year ago Hi there,
Get your issue fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.
Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.
To get started, please read our guide on creating a minimal reproduction.
We may close the issue if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.
Good luck,
The Renovate team
rarkins
commented
1 year ago A fork of the reproduction repo no longer reproduces, so I have changed the label
github-actions[bot]
commented
1 year ago When a bug has been marked as needing a reproduction, it means nobody can work on it until one is provided. In cases where no reproduction is possible, or the issue creator does not have the time to reproduce, we unfortunately need to close such issues as they are non-actionable and serve no benefit by remaining open. This issue will be closed after 7 days of inactivity.
abrain
commented
1 year ago I recently saw this still happening with v34, opening three PRs for pinning. Unfortunately, this was in a private repo. I'll see that I can create a public reproduction repo and test with v35.
abrain
commented
1 year ago Here is a new reproduction repo: https://github.com/abrain/renovate-issue-11680
It still happens with v35 and seems to be related to matchUpdateTypes in group presets. Details are provided in the repo's README.
How are you running Renovate?
Self-hosted
Please select which platform you are using if self-hosting.
Bitbucket Cloud (bitbucket.org)
If you're self-hosting Renovate, tell us what version of Renovate you run.
26.7.0
Describe the bug
When the
config:basepreset is extended in the configuration, dependency pinning is unexpectedly and hinderingly split by pin-{monorepo} groups, plus arenovate/pin-dependenciesbranch for "others".I reproduced the issue with a package.json file as small as this:
...and a configuration as minimalistic as:
Relevant debug logs
Logs
``` DEBUG: Using RE2 as regex engine DEBUG: Parsing configs DEBUG: Checking for config file in /usr/src/app/config DEBUG: File config "config": { "$schema": "https://docs.renovatebot.com/renovate-schema.json", "platform": "bitbucket", "username": "renovate@labelvier.nl", "password": "***********", "gitAuthor": "Renovate BotHave you created a minimal reproduction repository?
I have linked to a minimal reproduction repository in the bug description