search

renovatebot / renovate

Home of the Renovate CLI: Cross-platform Dependency Automation by Mend.io
https://mend.io/renovate
GNU Affero General Public License v3.0
17.66k stars 2.33k forks source link

Fix for #10464 added arbitrary constraints #12417

Closed astellingwerf closed 1 year ago

astellingwerf commented 3 years ago

How are you running Renovate?

Self-hosted

Please select which platform you are using if self-hosting.

GitLab self-hosted

If you're self-hosting Renovate, tell us what version of Renovate you run.

28.20.0

Describe the bug

With the commit 10ca7b3 for #10464, the addition of filtering of tags puts arbitrary constraints on what's considered the latest tag, while (as product documentation states) the versioning is a bit vague for Docker.

The filtering in findLatestStable always uses the Docker versioning, instead of the versioning that's configured for the dependency. With version numbers for JVM containers like 11.0.10_9.202103.181959-jre, they would not be considered stable, whereas the config.versioning with a regex for this package (set via a package rule) would.

Relevant debug logs

Logs ``` Copy/paste any log here, between the starting and ending backticks ```

Have you created a minimal reproduction repository?

No reproduction repository

HonkingGoose commented 3 years ago

@viceice Can you triage this issue please? I'm not sure if the new behavior is a regression or intended.

viceice commented 3 years ago

This is currently by design. 🤷‍♂️

astellingwerf commented 3 years ago

Looks like someone has hit by the same design decision, and is working around it: #12646

HonkingGoose commented 3 years ago

This is currently by design. 🤷‍♂️

If the new behavior is intended, maybe we can close the issue, if we're not going to change things?

What do you think @rarkins?

astellingwerf commented 3 years ago

I don't understand the design: "Despite versioning on Docker being extremely muddy, we must enforce some rules to find a few tags on a reliably but rather arbitrarily selected image, and that hope they make any sense for the image that is selected based on actual in-depth knowledge and configuration."

github-actions[bot] commented 1 year ago

Hi there,

Get your issue fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the issue if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

github-actions[bot] commented 1 year ago

When a bug has been marked as needing a reproduction, it means nobody can work on it until one is provided. In cases where no reproduction is possible, or the issue creator does not have the time to reproduce, we unfortunately need to close such issues as they are non-actionable and serve no benefit by remaining open. This issue will be closed after 7 days of inactivity.

github-actions[bot] commented 1 year ago

This bug report has been closed as we need a reproduction to work on this. If the original poster or anybody else with the same problem discovers that they can reproduce it, please create a new issue, and reference this issue.