Closed KayBestmann1123 closed 1 year ago
rarkins
commented
2 years ago ext.versions and ext.libraries reuse the same variable name: https://github.com/KayBestmann1123/renovatetest/blob/84e0c10551e5ee5c84ba503f0c4ec398f467514b/gradle/dependencies.gradle#L5-L13
Does the problem go away if you use different variable names?
KayBestmann1123
commented
2 years ago Please see the comment https://github.com/KayBestmann1123/renovatetest/commit/1b40984c79569eec454e9d88747dfa102e836db1#r64093727
Changed the variable name: Did not help.
rarkins
commented
2 years ago Reproduction forked to https://github.com/renovate-reproductions/13619
pujanshah3333
commented
2 years ago Hey any update here? I'm facing same issue.
hasanwhitesource
commented
2 years ago @rarkins I've tried to reproduce using the forked test data and received a suggested update to 5.0.5 for the plugin in question as expected instead of 4.5.3. here is a link to my generated pr renovate/configure.
@pujanshah3333 Did you try on a different repo or config?
github-actions[bot]
commented
2 years ago Hi there,
Help us by making a minimal reproduction repository.
Before we can start work on your issue we first need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.
To get started, please read our guide on creating a minimal reproduction to understand what is needed.
We may close the issue if you (or someone else) have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.
Good luck,
The Renovate team
KayBestmann1123
commented
2 years ago @hasanwhitesource is it possible that you've linked the wrong url? Because i can see neither a PR nor any by renovate created branch.
In addition the same mix up is still happening in the given test repository, as well as in multiple repositories on my end. For reference the suggested renovate commit from the given test repository: renovate/java-java
pujanshah3333
commented
2 years ago @rarkins I've tried to reproduce using the forked test data and received a suggested update to
5.0.5for the plugin in question as expected instead of4.5.3. here is a link to my generated pr renovate/configure.
Where do you see that?
@pujanshah3333 Did you try on a different repo or config?
I have tried with same config.
rarkins
commented
2 years ago You can see v5.0.5 in the body of the linked onboarding PR
JoergHeinicke5005
commented
2 years ago You can see v5.0.5 in the body of the linked onboarding PR
I guess you are referring to
We are getting similar from Renovate in our repositories:
But when it's actually creating the commit, it looks like:
rarkins
commented
2 years ago Let's wait on a minimal reproduction then.
github-actions[bot]
commented
2 years ago When a bug has been marked as needing a reproduction, it means nobody can work on it until one is provided. In cases where no reproduction is possible, or the issue creator does not have the time to reproduce, we unfortunately need to close such issues as they are non-actionable and serve no benefit by remaining open. This issue will be closed after 7 days of inactivity.
KayBestmann1123
commented
2 years ago @rarkins : I've updated the linked repository to create a PR to better highlight the issue and removed everything non-issue related so it's actually a minimal reproduction.
See the PR with the suggested correct change (Identical to @hasanwhitesource test PR 22 days ago):
https://github.com/KayBestmann1123/renovatetest/pull/6
->
See the actual created commit (or files changed) inside the repository with the incorrect change: Commit: https://github.com/KayBestmann1123/renovatetest/pull/6/commits/1fe82104982f292df2539eaab1b3f0f85f074999 Files changed: https://github.com/KayBestmann1123/renovatetest/pull/6/files
->
hasanwhitesource
commented
2 years ago @KayBestmann1123
I have forked your test repo and added this config and received the expected update.
Would you kindly verify and run on the latest renovate version and also check if my config satisfies your needs?
JoergHeinicke5005
commented
2 years ago @hasanwhitesource Do you know why it hasn't picked up spotbugs_annotations upgrade from 4.5.2 to 4.5.3 in your test repo?
hasanwhitesource
commented
2 years ago @zharinov Do we need a special config for the Gradle parser to identify dependencies in this file
zharinov
commented
2 years ago Unfortunately, we need to add support for this variable definition syntax
zharinov
commented
2 years ago Btw, I'm working on parsing library which would help to handle Gradle syntax variations: https://github.com/zharinov/good-enough-parser/
I had plans to port current Gradle implementation to use this library (actually, it was inspired by Gradle implementation)
JoergHeinicke5005
commented
2 years ago @zharinov Do we need a special config for the Gradle parser to identify dependencies in this file
Reading your last comments back then, @hasanwhitesource and @zharinov, I was confused as apparently Renovate worked within our setup with the versions of our dependencies specified in a separated file. We just recently noticed, Renovate is no longer picking up newer versions for our Java dependencies since quite some time. I figured that it's related to https://github.com/renovatebot/renovate/issues/13490, deprecation and eventually removal of deepExtract with Renovate 32. Can you confirm that removing functionality behind deepExtract config parameter made it working until Renovate 31 - and only now Renovate has the limitation with the separate file as stated? Are you aware of any background for removing deepExtract (discussions, reasoning for product decisions, or alike) or alternatives?
rarkins
commented
2 years ago We no longer run binaries as part of the extract process. DeepExtract required running gradle itself.
JoergHeinicke5005
commented
2 years ago @rarkins Is there some background information available on removing deepExtract feature? In the linked #13490 they are quoting you but I don't know from where. What's the fallback, to switch back to specifying all dependencies with their versions in build.gradle? I would not be too surprised if this makes this particular issue obsolete... but would like to confirm.
viceice
commented
2 years ago search issues and discussions for deepExtract.
we removed all manager code which depends on external tool for extraction because of too many errors / bugs and performance problems. those codes are replaced by js only implementations.
we issued deprecation warnings a long time before about that.
so it will never come back.
How are you running Renovate?
Self-hosted
If you're self-hosting Renovate, tell us what version of Renovate you run.
latest (31.28.5)
Please select which platform you are using if self-hosting.
github.com
If you're self-hosting Renovate, tell us what version of the platform you run.
No response
Describe the bug
Renovate tries to apply version of spotbugs_annotations java library to spotbugs gradle plugin. This results in a downgrade for spotbugs gradle plugins.
See for reference: https://github.com/KayBestmann1123/renovatetest/commit/1b40984c79569eec454e9d88747dfa102e836db1
Relevant debug logs
Logs
``` 2022-01-18T10:33:56.2663259Z Found online and idle hosted runner in the current repository's organization account that matches the required labels: 'ubuntu-latest' 2022-01-18T10:33:56.3637472Z Waiting for a Hosted runner in the 'organization' to pick this job... 2022-01-18T10:33:56.5866108Z Job is waiting for a hosted runner to come online. 2022-01-18T10:34:00.5350460Z Job is about to start running on the hosted runner: Hosted Agent (hosted) 2022-01-18T10:34:04.2530839Z Current runner version: '2.286.0' 2022-01-18T10:34:04.2558060Z ##[group]Operating System 2022-01-18T10:34:04.2558579Z Ubuntu 2022-01-18T10:34:04.2558828Z 20.04.3 2022-01-18T10:34:04.2559121Z LTS 2022-01-18T10:34:04.2559549Z ##[endgroup] 2022-01-18T10:34:04.2559846Z ##[group]Virtual Environment 2022-01-18T10:34:04.2560551Z Environment: ubuntu-20.04 2022-01-18T10:34:04.2560899Z Version: 20220111.1 2022-01-18T10:34:04.2561383Z Included Software: https://github.com/actions/virtual-environments/blob/ubuntu20/20220111.1/images/linux/Ubuntu2004-Readme.md 2022-01-18T10:34:04.2562132Z Image Release: https://github.com/actions/virtual-environments/releases/tag/ubuntu20%2F20220111.1 2022-01-18T10:34:04.2562596Z ##[endgroup] 2022-01-18T10:34:04.2562915Z ##[group]Virtual Environment Provisioner 2022-01-18T10:34:04.2563293Z 1.0.0.0-main-20211214-1 2022-01-18T10:34:04.2563579Z ##[endgroup] 2022-01-18T10:34:04.2564609Z ##[group]GITHUB_TOKEN Permissions 2022-01-18T10:34:04.2565239Z Actions: write 2022-01-18T10:34:04.2565743Z Checks: write 2022-01-18T10:34:04.2566118Z Contents: write 2022-01-18T10:34:04.2566451Z Deployments: write 2022-01-18T10:34:04.2566745Z Discussions: write 2022-01-18T10:34:04.2567082Z Issues: write 2022-01-18T10:34:04.2567421Z Metadata: read 2022-01-18T10:34:04.2567731Z Packages: write 2022-01-18T10:34:04.2568052Z Pages: write 2022-01-18T10:34:04.2568379Z PullRequests: write 2022-01-18T10:34:04.2568707Z RepositoryProjects: write 2022-01-18T10:34:04.2569070Z SecurityEvents: write 2022-01-18T10:34:04.2569393Z Statuses: write 2022-01-18T10:34:04.2569716Z ##[endgroup] 2022-01-18T10:34:04.2573508Z Secret source: Actions 2022-01-18T10:34:04.2573969Z Prepare workflow directory 2022-01-18T10:34:04.3438512Z Prepare all required actions 2022-01-18T10:34:04.3625261Z Getting action download info 2022-01-18T10:34:04.6043482Z Download action repository 'actions/checkout@v2' (SHA:ec3a7ce113134d7a93b817d10a8272cb61118579) 2022-01-18T10:34:05.2756435Z Download action repository 'actions/setup-node@v2' (SHA:1f8c6b94b26d0feae1e387ca63ccbdc44d27b561) 2022-01-18T10:34:05.8921017Z Download action repository 'actions/setup-java@v2' (SHA:f0bb91606209742fe3ea40199be2f3ef195ecabf) 2022-01-18T10:34:06.6889874Z ##[group]Run actions/checkout@v2 2022-01-18T10:34:06.6890165Z with: 2022-01-18T10:34:06.6890393Z repository: KayBestmann1123/renovatetest 2022-01-18T10:34:06.6890913Z token: *** 2022-01-18T10:34:06.6891116Z ssh-strict: true 2022-01-18T10:34:06.6891334Z persist-credentials: true 2022-01-18T10:34:06.6891562Z clean: true 2022-01-18T10:34:06.6891771Z fetch-depth: 1 2022-01-18T10:34:06.6891952Z lfs: false 2022-01-18T10:34:06.6892150Z submodules: false 2022-01-18T10:34:06.6892352Z ##[endgroup] 2022-01-18T10:34:06.9547448Z Syncing repository: KayBestmann1123/renovatetest 2022-01-18T10:34:06.9549565Z ##[group]Getting Git version info 2022-01-18T10:34:06.9550336Z Working directory is '/home/runner/work/renovatetest/renovatetest' 2022-01-18T10:34:06.9551628Z [command]/usr/bin/git version 2022-01-18T10:34:06.9679586Z git version 2.34.1 2022-01-18T10:34:06.9681125Z ##[endgroup] 2022-01-18T10:34:06.9681536Z Deleting the contents of '/home/runner/work/renovatetest/renovatetest' 2022-01-18T10:34:06.9683197Z ##[group]Initializing the repository 2022-01-18T10:34:06.9688006Z [command]/usr/bin/git init /home/runner/work/renovatetest/renovatetest 2022-01-18T10:34:06.9765822Z hint: Using 'master' as the name for the initial branch. This default branch name 2022-01-18T10:34:06.9766587Z hint: is subject to change. To configure the initial branch name to use in all 2022-01-18T10:34:06.9766956Z hint: of your new repositories, which will suppress this warning, call: 2022-01-18T10:34:06.9767347Z hint: 2022-01-18T10:34:06.9767755Z hint: git config --global init.defaultBranchHave you created a minimal reproduction repository?
I have linked to a minimal reproduction repository in the bug description