Specifying sourceUrl on config.js no longer working

patrickhuy commented 2 years ago

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us what version of Renovate you run.

32.7.5

Please select which platform you are using if self-hosting.

GitHub Enterprise Server

If you're self-hosting Renovate, tell us what version of the platform you run.

3.0.0

Was this something which used to work for you, and then stopped?

It used to work, and then stopped

Describe the bug

After upgrading from Renovate 32.7.0 (32.7.1 also still works) to Renovate 32.7.5 I'm getting validation error messages like this when running with a config.js which manually specifies a sourceUrl in some package rules. Specification on config.js:

  {
    "matchPackagePatterns": ["^com.sap.cloud.security"],
    "matchDatasources": ["maven"],
    "sourceUrl": "https://github.com/SAP/cloud-security-xsuaa-integration"
  },
  {
    "matchPackagePatterns": ["^org.eclipse.jetty"],
    "matchDatasources": ["maven"],
    "sourceUrl": "https://github.com/eclipse/jetty.project"
  },
  {
    "matchPackagePatterns": ["^org.liquibase"],
    "matchDatasources": ["maven"],
    "sourceUrl": "https://github.com/liquibase/liquibase"
  }

Error message:

14:24:54           "validationMessage": "Invalid configuration option: packageRules[3].sourceUrl, Invalid configuration option: packageRules[4].sourceUrl, Invalid configuration option: packageRules[5].sourceUrl, Invalid configuration option: packageRules[6].sourceUrl, Invalid configuration option: packageRules[7].sourceUrl, Invalid configuration option: packageRules[8].sourceUrl",

In previous versions this used to work great. Looking at the changelog I identified https://github.com/renovatebot/renovate/pull/14688 in version 32.7.2 as a candidate for causing this but I'm not sure.

Relevant debug logs

Logs

``` 14:24:54 "validationMessage": "Invalid configuration option: packageRules[3].sourceUrl, Invalid configuration option: packageRules[4].sourceUrl, Invalid configuration option: packageRules[5].sourceUrl, Invalid configuration option: packageRules[6].sourceUrl, Invalid configuration option: packageRules[7].sourceUrl, Invalid configuration option: packageRules[8].sourceUrl", ```

Have you created a minimal reproduction repository?

No reproduction repository

rarkins commented 2 years ago

I've created https://github.com/renovatebot/renovate/pull/14842

I guess we'll need to decide if/how to support sourceUrl officially for self-hosted. The reason we avoid it by default is so that nobody can "pollute" our changelog cache intentionally or by accident and people see the wrong log.

renovate-release commented 2 years ago

:tada: This issue has been resolved in version 32.10.1 :tada:

The release is available on:

GitHub release
32.10.1

Your semantic-release bot :package::rocket:

renovatebot / renovate