renovatebot / renovate

Home of the Renovate CLI: Cross-platform Dependency Automation by Mend.io
https://mend.io/renovate
GNU Affero General Public License v3.0
17.6k stars 2.32k forks source link

False positive on Gradle functions with 3 string arguments #14913

Closed TWiStErRob closed 2 years ago

TWiStErRob commented 2 years ago

How are you running Renovate?

WhiteSource Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

Please select which platform you are using if self-hosting.

github.com

If you're self-hosting Renovate, tell us what version of the platform you run.

No response

Was this something which used to work for you, and then stopped?

I never saw this working

Describe the bug

I just installed renovate on https://github.com/TWiStErRob/net.twisterrob.colorfilters/pull/46

It somehow detected this line as a dependency:

https://github.com/TWiStErRob/net.twisterrob.colorfilters/blob/ce585afdd4c9b837c1d44eb9cf64da06675abb90/buildSrc/src/main/kotlin/build.android-base.conventions.gradle.kts#L90

and failed to find it...

image

Relevant debug logs

https://app.renovatebot.com/dashboard#github/TWiStErRob/net.twisterrob.colorfilters/621778721

Have you created a minimal reproduction repository?

No reproduction, but I have linked to a public repo where it occurs

github-actions[bot] commented 2 years ago

Hi there,

Help us by making a minimal reproduction repository.

Before we can start work on your issue we first need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction to understand what is needed.

We may close the issue if you (or someone else) have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

github-actions[bot] commented 2 years ago

Hi there,

We have found that there's a problem with the logs. Depending on which situation applies follow one, some or all of these instructions.

No logs at all

If there's no log posted yet, we need you to find and copy/paste the log into the issue template.

Finding logs on hosted app

Click me to read instructions If you use the Renovate app (GitHub): 1. Go to the affected PR, and search for "View repository job log here" 1. Click on the link to go to the "WhiteSource Renovate Dashboard" and log in 1. You are now in the correct repository log overview screen 1. Copy/paste the correct log 1. Follow the steps in the **formatting your logs** section

Finding logs when self-hosting

Click me to read instructions If you're running self-hosted, run with `LOG_LEVEL=debug` in your environment variables and search for whatever dependency/branch/PR that is causing the problem.

Insufficient logs

Click me to read instructions If you already provided logs, and the Renovate team said they are not enough, follow the instructions from the **No logs at all** section.

Formatting your logs

Click me to read instructions Please put your logs in a `
` and `` element like this:
Click me to see logs ``` Copy/paste any log here, between the starting and ending backticks ```
rarkins commented 2 years ago

Hi, thanks for reporting. If you have the time, please reduce it to a minimal reproduction and embed the relevant logs here. Instructions for both are above

TWiStErRob commented 2 years ago

I didn't see anything in the logs (DEBUG), just that it found the dependency in that file, which we know from the warning too.

rarkins commented 2 years ago

OK, next step is working out if only a small file is needed to trigger the mistaken dep or if it only happens within a larger file

TWiStErRob commented 2 years ago

More examples from different repos.

https://github.com/TWiStErRob/net.twisterrob.colorfilters/blob/ce585afdd4c9b837c1d44eb9cf64da06675abb90/buildSrc/src/main/kotlin/build.android-base.conventions.gradle.kts#L90 https://app.renovatebot.com/dashboard#github/TWiStErRob/net.twisterrob.colorfilters/621778721

https://github.com/TWiStErRob/net.twisterrob.cinema/blob/cfca8bf85aa254c683fc81df667c8436884bb493/Heroku/backend/sync/build.gradle.kts#L19 https://app.renovatebot.com/dashboard#github/TWiStErRob/net.twisterrob.cinema/621778708

https://github.com/TWiStErRob/net.twisterrob.gradle/blob/96fd3bef4145a6c8143c86a21afc4fe34b86728c/build.gradle.kts#L100-L102 https://app.renovatebot.com/dashboard#github/TWiStErRob/net.twisterrob.gradle/621778706

renovate-release commented 2 years ago

:tada: This issue has been resolved in version 32.10.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

TWiStErRob commented 2 years ago

uh, @viceice, does this mean that I can just remove the ignores now? this goes live immediately?

TWiStErRob commented 2 years ago

Thank you for the very very quick fix! :)

viceice commented 2 years ago

no, i think @rarkins will bring it live tomorrow.

rarkins commented 2 years ago

No, doesn't go live in the app immediately