renovatebot / renovate

Home of the Renovate CLI: Cross-platform Dependency Automation by Mend.io
https://mend.io/renovate
GNU Affero General Public License v3.0
17.61k stars 2.32k forks source link

Turn `migratePresets` into a non-self-hosted property #16605

Open astellingwerf opened 2 years ago

astellingwerf commented 2 years ago

What would you like Renovate to be able to do?

The property migratePresets can be used to migrate presets (shocker, I know!). Today, the property is a self-hosted property. I'd like to suggest that I'd would be of more use if the property could also be set in a repo or preset context. More specifically: whenever implementable, it should be possible for a "legacy" preset to include a migratePresets declaration about itself and its replacement, in order to auto-discover the new prefered situation.

If you have any ideas on how this should be implemented, please tell us here.

Not really.

Is this a feature you are interested in implementing yourself?

Maybe

viceice commented 2 years ago

doesn't make sense, as you still need to run renovate on it.

so the request would be to allow migrating presets instead. so please update issue

astellingwerf commented 2 years ago

That's what configMigration=true achieves if migratePresets is also set. I don't see a reason to update the issue.

rarkins commented 2 years ago

So I think ideally it would have been called something like "remapPresets" because it doesn't migrate anything itself per se. But now that we have it, is it work renaming it?

HonkingGoose commented 1 year ago

If the current name is confusing we should pick a better name, even if that means more work. Good names help to understand what the bot is going to do. 😄


Edit: I see we also mention remapPresets in this issue:

Do you want a new issue to track renaming migratePresets to remapPresets?

rarkins commented 1 year ago

Yes, let's have a separate issue. We need to remember to migrate self-hosted config in this case

HonkingGoose commented 1 year ago

Yes, let's have a separate issue.

Done, see:

We need to remember to migrate self-hosted config in this case

Can you tell me where that todo belongs? I don't understand if it's for this issue or the new separate issue. 🙈

rarkins commented 1 year ago

Within the same issue

Finkregh commented 3 months ago

This would be really helpful, as it would allow rename files: