Closed dylang closed 1 year ago
I have linked to a minimal reproduction repository in the bug description
I don't see the link to your minimal reproduction repository. Can you put the link in a new comment?
Relevant logs:
DEBUG: recreateClosed is false (repository=magic/test-renovate, branch=renovate/chalk-5.x)
DEBUG: findPr(renovate/chalk-5.x, fix(deps): update dependency chalk to v5, !open) (repository=magic/test-renovate, branch=renovate/chalk-5.x)
DEBUG: prAlreadyExisted=false (repository=magic/test-renovate, branch=renovate/chalk-5.x)
It seems to be looking for the correct branch/title combination, but does not find it.
Also relevant:
DEBUG: getPrList success (repository=magic/test-renovate)
"pullsTotal": 12,
"requestsTotal": 1,
"apiQuotaAffected": true
It finds 12 PRs, but in your screenshot I see #11
so that number look about right
maybe a wrongly configured username? so renovate doesn't find it's own PR's?
Based on the screenshot it looks like a regular (non-app) user, so I was hoping that's not the case
It finds 12 PRs, but in your screenshot I see #11 so that number look about right
The log is not from the same run as a screenshot. I've been trying over and over with different settings. 😅
I have linked to a minimal reproduction repository in the bug description
I don't see the link to your minimal reproduction repository. Can you put the link in a new comment?
Sorry, that was a mistake. I created a minimal repo, but it is on my company's Github Enterprise server.
Relevant logs:
DEBUG: recreateClosed is false (repository=magic/test-renovate, branch=renovate/chalk-5.x) DEBUG: findPr(renovate/chalk-5.x, fix(deps): update dependency chalk to v5, !open) (repository=magic/test-renovate, branch=renovate/chalk-5.x) DEBUG: prAlreadyExisted=false (repository=magic/test-renovate, branch=renovate/chalk-5.x) It seems to be looking for the correct branch/title combination, but does not find it.
It seems like:
Found the bug!
'magic/test-renovate'
.sourceRepo: 'Magic/test-renovate',
Magic
vs magic
. 😅 This is where this is occurring. https://github.com/renovatebot/renovate/blob/main/lib/modules/platform/github/index.ts#L722
So I have a workaround - fix the config casing! But we might want to address this for everyone else that has mixed case repo names.
From Github's API, the repo is returned as
sourceRepo: 'Magic/test-renovate'
Which endpoint are you using to find that? I am having a very similar issue but as far as I can tell our org and repo are all lowercase, and I don't find the sourceRepo
key in https://api.github.com/repos/{owner}/{repo}/pulls
I am seeing a similar issue: closing the PR and it recreates it if I run the job immediately after. This is also a large repo with >1,000 PRs (but they are all closed, only 1 open ATM)
:tada: This issue has been resolved in version 34.66.0 :tada:
The release is available on:
34.66.0
Your semantic-release bot :package::rocket:
How are you running Renovate?
Mend Renovate hosted app on github.com
If you're self-hosting Renovate, tell us what version of Renovate you run.
34.55.0
If you're self-hosting Renovate, select which platform you are using.
None
If you're self-hosting Renovate, tell us what version of the platform you run.
GitHub Enterprise Server 3.5.7
Was this something which used to work for you, and then stopped?
It used to work, and then stopped
Describe the bug
We close PR's for dependencies we can't yet merge, like
chalk v5
.Next time Renovate runs, it creates a new PR for that same dependency.
It is not re-opening the closed PR, it's creating a new one. It doesn't matter if the branch was left behind or deleted.
I created a fresh repo so the debug long wouldn't be too long.
The PR's are not marked
immortal
:Expectation: https://docs.renovatebot.com/key-concepts/pull-requests/#ignoring-prs
This has been happening for a while, possibly since I've added these settings:
platform: 'github'
,endpoint: 'https://github.company.com/api/v3/'
,timeout
concurrentRequestLimit
maxRequestsPerSecond
. Maybe one of them is causing this?Relevant debug logs
In this example, a PR for Chalk 5 is created, even though it's been closed before.
Logs
``` + yarn renovate DEBUG: Using RE2 as regex engine DEBUG: Parsing configs DEBUG: Checking for config file in /home/jenkins/workspace/ia_medallia-org_renovate_PR-1838/renovate.js DEBUG: Converting GITHUB_COM_TOKEN into a global host rule DEBUG: File config "config": { "platform": "github", "endpoint": "https://github.medallia.com/api/v3/", "repositories": ["magic/test-renovate"], "schedule": [ "every weekday before 10am", "every weekday after 9pm", "every weekend" ], "timezone": "US/Eastern", "npmrc": "***********", "packageRules": [ { "matchDatasources": ["docker"], "registryUrls": ["https://virtual-docker.artifactory.eng.medallia.com/"] }, { "matchDatasources": ["gradle"], "matchPackagePatterns": ["medallia"], "registryUrls": ["https://artifactory.eng.medallia.com/virtual-gradle"] } ], "hostRules": [ { "hostType": "npm", "username": "fowler", "password": "***********", "timeout": 300000 }, { "hostType": "maven", "matchHost": "artifactory.eng.medallia.com", "username": "fowler", "password": "***********", "timeout": 300000 }, { "hostType": "gradle", "matchHost": "artifactory.eng.medallia.com", "username": "fowler", "password": "***********", "timeout": 300000 }, { "hostType": "docker", "matchHost": "virtual-docker.artifactory.eng.medallia.com", "username": "fowler", "password": "***********", "timeout": 300000 }, { "hostType": "docker", "matchHost": "virtual-docker.martifactory.io", "username": "fowler", "password": "***********", "timeout": 300000 }, { "matchHost": "api.github.com", "concurrentRequestLimit": 1, "maxRequestsPerSecond": 1 }, { "matchHost": "artifactory.eng.medallia.com", "concurrentRequestLimit": 5, "maxRequestsPerSecond": 5 } ], "logFileLevel": "debug", "requireConfig": "optional", "allowCustomCrateRegistries": true, "allowPlugins": true, "allowScripts": true, "exposeAllEnv": true, "suppressNotifications": [], "executionTimeout": 60, "onboardingConfig": { "$schema": "https://docs.renovatebot.com/renovate-schema.json", "extends": [ "config:base", ":rebaseStalePrs", ":semanticCommits", ":maintainLockFilesWeekly", "schedule:nonOfficeHours" ], "configMigration": true, "commitMessagePrefix": "chore(deps): {{{updateType}}} -", "postUpdateOptions": ["yarnDedupeFewer"], "ignoreDeps": [], "packageRules": [ {"groupName": "Argus Packages", "matchPackagePatterns": ["^@m/argus"]}, { "groupName": "Magic Packages", "matchPackagePatterns": [ "^@m/magic", "^@m/babel-preset-magic", "^@m/eslint-plugin-magic" ] }, {"groupName": "Alchemy Packages", "matchPackagePatterns": ["^@m/alchemy"]} ] } } DEBUG: CLI config "config": {} DEBUG: Env config "config": { "hostRules": [ {"hostType": "github", "matchHost": "github.com", "token": "***********"} ], "endpoint": "https://github.medallia.com/api/v3", "token": "***********" } DEBUG: Combined config "config": { "platform": "github", "endpoint": "https://github.medallia.com/api/v3", "repositories": ["magic/test-renovate"], "schedule": [ "every weekday before 10am", "every weekday after 9pm", "every weekend" ], "timezone": "US/Eastern", "npmrc": "***********", "packageRules": [ { "matchDatasources": ["docker"], "registryUrls": ["https://virtual-docker.artifactory.eng.medallia.com/"] }, { "matchDatasources": ["gradle"], "matchPackagePatterns": ["medallia"], "registryUrls": ["https://artifactory.eng.medallia.com/virtual-gradle"] } ], "hostRules": [ { "hostType": "npm", "username": "fowler", "password": "***********", "timeout": 300000 }, { "hostType": "maven", "matchHost": "artifactory.eng.medallia.com", "username": "fowler", "password": "***********", "timeout": 300000 }, { "hostType": "gradle", "matchHost": "artifactory.eng.medallia.com", "username": "fowler", "password": "***********", "timeout": 300000 }, { "hostType": "docker", "matchHost": "virtual-docker.artifactory.eng.medallia.com", "username": "fowler", "password": "***********", "timeout": 300000 }, { "hostType": "docker", "matchHost": "virtual-docker.martifactory.io", "username": "fowler", "password": "***********", "timeout": 300000 }, { "matchHost": "api.github.com", "concurrentRequestLimit": 1, "maxRequestsPerSecond": 1 }, { "matchHost": "artifactory.eng.medallia.com", "concurrentRequestLimit": 5, "maxRequestsPerSecond": 5 }, {"hostType": "github", "matchHost": "github.com", "token": "***********"} ], "logFileLevel": "debug", "requireConfig": "optional", "allowCustomCrateRegistries": true, "allowPlugins": true, "allowScripts": true, "exposeAllEnv": true, "suppressNotifications": [], "executionTimeout": 60, "onboardingConfig": { "$schema": "https://docs.renovatebot.com/renovate-schema.json", "extends": [ "config:base", ":rebaseStalePrs", ":semanticCommits", ":maintainLockFilesWeekly", "schedule:nonOfficeHours" ], "configMigration": true, "commitMessagePrefix": "chore(deps): {{{updateType}}} -", "postUpdateOptions": ["yarnDedupeFewer"], "ignoreDeps": [], "packageRules": [ {"groupName": "Argus Packages", "matchPackagePatterns": ["^@m/argus"]}, { "groupName": "Magic Packages", "matchPackagePatterns": [ "^@m/magic", "^@m/babel-preset-magic", "^@m/eslint-plugin-magic" ] }, {"groupName": "Alchemy Packages", "matchPackagePatterns": ["^@m/alchemy"]} ] }, "token": "***********" } DEBUG: Adding trailing slash to endpoint DEBUG: Found valid git version: 2.34.1 DEBUG: Detected GitHub Enterprise Server, version: 3.5.7 DEBUG: Platform config "platformConfig": { "hostType": "github", "endpoint": "https://github.medallia.com/api/v3/", "isGHApp": false, "isGhe": true, "gheVersion": "3.5.7", "userDetails": {"username": "service-continuous-deliver", "name": null}, "userEmail": "service-continuous-deliver@medallia.com" }, "renovateUsername": "service-continuous-deliver" DEBUG: Using platform gitAuthor: nullHave you created a minimal reproduction repository?
I have created a minimal reproduction repository, but it is on Github Enterprise.