search

renovatebot / renovate

Home of the Renovate CLI: Cross-platform Dependency Automation by Mend.io
https://mend.io/renovate
GNU Affero General Public License v3.0
17.66k stars 2.33k forks source link

sbt: Support %%% dependencies (e.g. Scala.js) #19650

Closed mohe2015 closed 1 year ago

mohe2015 commented 1 year ago

What would you like Renovate to be able to do?

When specifying a sbt dependency with

libraryDependencies ++= Seq(
    "com.lihaoyi" %%% "utest" % "0.8.1" % Test,
)

renovate does not detect it. This is syntax that is used by e.g. https://www.scala-js.org/doc/project/dependencies.html

If you have any ideas on how this should be implemented, please tell us here.

A test would need to be added to https://github.com/renovatebot/renovate/blob/main/lib/modules/manager/sbt/__fixtures__/sample.sbt I think and then %%% should probably behave like %% as that's what happens on the JVM.

Also seems like you would need to add another option at https://github.com/renovatebot/renovate/blob/36e7cb6e6909f27e26e98538fc42e5fcb048f24b/lib/modules/manager/sbt/extract.ts#L203 which looks straightforward at first sight.

Is this a feature you are interested in implementing yourself?

Yes

github-actions[bot] commented 1 year ago

Hi there,

Get your issue fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the issue if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

mohe2015 commented 1 year ago

https://github.com/mohe2015/scalajs-tutorial should be good for minimal reproduction.

I'm already working on a fix though.